From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Vishnu Reddy <busanna.reddy@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v4 6/6] media: iris: Introduce vpu ops for vpu4 with necessary hooks
Date: Fri, 16 Jan 2026 11:46:07 +0100 [thread overview]
Message-ID: <98481299-4db3-41f3-a974-d9d0075d92e0@kernel.org> (raw)
In-Reply-To: <54b29b03-4166-60d9-d553-d0e655749da4@oss.qualcomm.com>
On 16/01/2026 10:51, Dikshita Agarwal wrote:
>
>
> On 12/10/2025 6:06 PM, Vikash Garodia wrote:
>> Add power sequence for vpu4 by reusing from previous generation wherever
>> possible. Hook up vpu4 op with vpu4 specific implemtation or resue from
>> earlier generation wherever feasible, like clock calculation in this
>> case.
>>
>> Co-developed-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
>> ---
>> drivers/media/platform/qcom/iris/Makefile | 1 +
>> .../platform/qcom/iris/iris_platform_common.h | 7 +
>> drivers/media/platform/qcom/iris/iris_vpu4x.c | 369 +++++++++++++++++++++
>> drivers/media/platform/qcom/iris/iris_vpu_common.h | 1 +
>> 4 files changed, 378 insertions(+)
>>
>
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Thank you for reviewing this code. I would like to point that it took
one month for Qualcomm to review this Qualcomm patch and in the same
time Vikash is sending emails (more than one!) that Bryan does not
review that fast as expected.
I do not find it acceptable approach to harass community reviewers that
way. Even if you do it internally, not on the lists.
I think this review timeline is final argument for Vikash to stop
pushing such narratives and complains, because your review is expected
to be BEFORE the maintainer upper in the upstream flow.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 12:35 [PATCH v4 0/6] media: iris: prepare support for video codecs on Qcom vpu4 platform Vikash Garodia
2025-12-10 12:35 ` [PATCH v4 1/6] media: iris: Add support for multiple clock sources Vikash Garodia
2026-01-16 9:38 ` Dikshita Agarwal
2025-12-10 12:36 ` [PATCH v4 2/6] media: iris: Add support for multiple TZ content protection(CP) configs Vikash Garodia
2026-01-16 9:39 ` Dikshita Agarwal
2025-12-10 12:36 ` [PATCH v4 3/6] media: iris: Introduce buffer size calculations for vpu4 Vikash Garodia
2026-01-16 10:31 ` Dikshita Agarwal
2025-12-10 12:36 ` [PATCH v4 4/6] media: iris: Move vpu register defines to common header file Vikash Garodia
2025-12-10 15:03 ` Dmitry Baryshkov
2025-12-10 15:47 ` Vikash Garodia
2025-12-10 21:26 ` Bryan O'Donoghue
2025-12-10 23:35 ` Dmitry Baryshkov
2026-01-16 9:45 ` Dikshita Agarwal
2025-12-10 12:36 ` [PATCH v4 5/6] media: iris: Move vpu35 specific api to common to use for vpu4 Vikash Garodia
2026-01-16 9:47 ` Dikshita Agarwal
2025-12-10 12:36 ` [PATCH v4 6/6] media: iris: Introduce vpu ops for vpu4 with necessary hooks Vikash Garodia
2026-01-16 9:51 ` Dikshita Agarwal
2026-01-16 10:46 ` Krzysztof Kozlowski [this message]
2026-01-16 11:27 ` Vikash Garodia
2026-01-16 11:54 ` Krzysztof Kozlowski
2026-01-16 12:58 ` Bryan O'Donoghue
2026-01-16 11:30 ` Dikshita Agarwal
2026-01-16 11:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98481299-4db3-41f3-a974-d9d0075d92e0@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox