From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Karel Zak <kzak@redhat.com>
Cc: Sheng Yong <shengyong2021@gmail.com>,
xiang@kernel.org, chao@kernel.org, zbestahu@gmail.com,
jefflexu@linux.alibaba.com, dhavale@google.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Sheng Yong <shengyong1@xiaomi.com>,
Wang Shuai <wangshuai12@xiaomi.com>
Subject: Re: [PATCH v3 2/2] erofs: add 'offset' mount option for file-backed & bdev-based mounts
Date: Tue, 8 Apr 2025 17:11:14 +0800 [thread overview]
Message-ID: <98585dd8-d0b6-4000-b46d-a08c64eae44d@linux.alibaba.com> (raw)
In-Reply-To: <gk7jzl7pktrdpznqp2hiuflx56xyttw4v4z3epia2ziw4oz547@cft7fyeoirfr>
On 2025/4/8 16:46, Karel Zak wrote:
> On Mon, Apr 07, 2025 at 11:49:31PM +0800, Gao Xiang wrote:
>> On 2025/4/7 19:40, Karel Zak wrote:
>>> We can improve it in libmount and add any if-erofs hack there, but my
>>> suggestion is to select a better name for the mount option. For
>>> example, erofsoff=, erostart=, fsoffset=, start=, or similar.
>>
>> Thanks for your suggestion!
>>
>> it's somewhat weird to use erofsprefix here, I think fsoffset
>> may be fine.
>
> Yes, fsoffset sounds good. I anticipate more filesystems will support
> file-backed mounts in the future, making this option reusable.
From my own kernel perspective, it's not possible for the majority
of read-write fses especially have nested transaction (like
`current->journal_info`) in addition to many deadlock factors
without extra workqueue contexts. But for erofs it's safe.
Thanks,
Gao Xiang
prev parent reply other threads:[~2025-04-08 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 11:05 [PATCH v3 1/2] erofs: set error to bio if file-backed IO fails Sheng Yong
2025-04-07 11:05 ` [PATCH v3 2/2] erofs: add 'offset' mount option for file-backed & bdev-based mounts Sheng Yong
2025-04-07 11:40 ` Karel Zak
2025-04-07 15:49 ` Gao Xiang
2025-04-08 8:46 ` Karel Zak
2025-04-08 9:11 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98585dd8-d0b6-4000-b46d-a08c64eae44d@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhavale@google.com \
--cc=jefflexu@linux.alibaba.com \
--cc=kzak@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shengyong1@xiaomi.com \
--cc=shengyong2021@gmail.com \
--cc=wangshuai12@xiaomi.com \
--cc=xiang@kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox