From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751515AbdKVBpu (ORCPT ); Tue, 21 Nov 2017 20:45:50 -0500 Received: from mga14.intel.com ([192.55.52.115]:9536 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdKVBpt (ORCPT ); Tue, 21 Nov 2017 20:45:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,435,1505804400"; d="scan'208";a="1247066735" Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> <20171121151714.GC20440@krava> From: "Jin, Yao" Message-ID: <986b0bad-7082-f682-8dcd-5b056e2316d0@linux.intel.com> Date: Wed, 22 Nov 2017 09:45:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171121151714.GC20440@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2017 11:17 PM, Jiri Olsa wrote: > On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote: >> In current stat-shadow.c, the rblist deleting is ignored. >> >> The patch reconstructs the codes of rblist init/free, and adds >> the implementation to node_delete method of rblist. >> >> This patch also does: >> >> 1. Add the ctx/type/stat into rbtree keys because we will >> use this rbtree to maintain shadow metrics to replace original >> a couple of static arrays for supporting per-thread shadow stats. >> >> 2. Create a static runtime_stat variable 'rt_stat' which >> will log the shadow metrics by default. > > please make that separate patches then, > one patch - one logical change > > thanks, > jirka > OK, I will separate the patches. Thanks Jin Yao