public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	brouer@redhat.com, john.fastabend@gmail.com
Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer
Date: Mon, 5 Mar 2018 10:43:41 +0800	[thread overview]
Message-ID: <986bd816-2452-9eca-ec8a-ce267ef49a2d@redhat.com> (raw)
In-Reply-To: <20180304.183811.344767417258525977.davem@davemloft.net>



On 2018年03月05日 07:38, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Fri,  2 Mar 2018 17:29:14 +0800
>
>> XDP_REDIRECT support for mergeable buffer was removed since commit
>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
>> case"). This is because we don't reserve enough tailroom for struct
>> skb_shared_info which breaks XDP assumption. So this patch fixes this
>> by reserving enough tailroom and using fixed size of rx buffer.
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> Changes from V1:
>> - do not add duplicated tracepoint when redirection fails
> Applied to net-next, thanks Jason.

Hi David,

Consider the change is not large, any chance to make it for -net to keep 
XDP redirection work?

Thanks

  reply	other threads:[~2018-03-05  2:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  9:29 [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer Jason Wang
2018-03-02 16:07 ` Jesper Dangaard Brouer
2018-03-05  2:39   ` Jason Wang
2018-03-02 17:36 ` Michael S. Tsirkin
2018-03-05  2:41   ` Jason Wang
2018-03-04 23:38 ` David Miller
2018-03-05  2:43   ` Jason Wang [this message]
2018-03-05  3:16     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=986bd816-2452-9eca-ec8a-ce267ef49a2d@redhat.com \
    --to=jasowang@redhat.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox