From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756529AbcC2J1J (ORCPT ); Tue, 29 Mar 2016 05:27:09 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:50964 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756410AbcC2J1G (ORCPT ); Tue, 29 Mar 2016 05:27:06 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Sinan Kaya , kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, Baptiste Reynal , vikrams@codeaurora.org, marc.zyngier@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vinod.koul@intel.com, Alex Williamson , agross@codeaurora.org, Dan Carpenter , shankerd@codeaurora.org Subject: Re: [PATCH V3 1/3] vfio, platform: add support for ACPI while detecting the reset driver Date: Tue, 29 Mar 2016 11:25:47 +0200 Message-ID: <98854818.NJS35fvhsb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1459172124-6730-2-git-send-email-okaya@codeaurora.org> References: <1459172124-6730-1-git-send-email-okaya@codeaurora.org> <1459172124-6730-2-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:EQaTGJCX+vBecEqPQx9589PvnlY7C7XASFYas5x/SQbcHpsmzyN 1FFRmmsqwybYxRXxn3gmxaXR9Oo4zwlwIgyIPr8Af80F7KYTJyqoCQ2lTC5X/NROGl6W+Fb rlO7t18XCPiq8RZmCiDqttaDikpLDMi8nc4ljMxS7fgh/QdfuLsJVQxK0bPzXqZPV9JCsii PLHEEDn88t018KDmBm59g== X-UI-Out-Filterresults: notjunk:1;V01:K0:VUTHCjcl3a8=:3gjwi+dITfnRUup15r7wfr Zv8T/ovuDKwVojzd23k5Y7riLFTEFfY4MNIQNSLN6vZHAllHBOSEgmC7FLxbbM8m86hPjtGD6 HuNRzXf792zUI93MYlQCJ5pQhst+8MkpXMBRjKyf1hCRk8jYc5ZdDWqFmN8Lrmdls2/KZaDr0 BLQyZUH0SybVl1B1oQjQUc76MNZFKfdgFiEJKMj6ZC5n3amJH+t67Zq/gdugFgi9mEBmujzUl ilTaxUyVLx2pKDk9oVWYLfQvdrwCgaz8GcStaDLffpa171Ml65h4lwYHgHwC5FojHFOooBzyD vo4HKM6yJJhcsC85IrbWQdxtNxUIDwy2bRUfK/pdQGYcLVFYmLs+oB41G/icK6nTeopzqDkNE fOMhrRy1K19O756LjUiP7+pr8/Vdug6frWyBBRM45UDYSe+D5paU56EayMwQDUN2iHH+WZy2t L9lKLYwqxSMmUGsJ0SFrTdH4dYcpP4QAMh3yngsXgqz5gttgYtE7ZupjYt4vxHLXQLv7zhi6c tmXfH7KKdqUK4tcYqIdoueqmKHkCMAIOmDAh7tNprtzTkPYEVXRU64ZMBsTjphyuStXCiYOuj vuVl980PvZ5f+DXJb33ZTlwmN2MAD89qWcg42kwHOLVWRnvvJ5wczl6qmXjYmZtOl/83v7cip ho5yF7iFlUzIN8w1SiCvQmVtRoLgOSMvwUZp1H+AKVI17DuAoB2k1UqgyzY/aIaJGQbxchZAq IoLS6MG8Tc/60O7E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 28 March 2016 09:35:22 Sinan Kaya wrote: > The code is using the compatible DT string to associate a reset driver with > the actual device itself. The compatible string does not exist on ACPI > based systems. HID is the unique identifier for a device driver instead. > The change allows a driver to register with DT compatible string or ACPI > HID and then match the object with one of these conditions. > > Rules for loading the reset driver are as follow: > - ACPI HID needs match for ACPI systems > - DT compat needs to match for OF systems > > Tested-by: Eric Auger (device tree only) > Tested-by: Shanker Donthineni (ACPI only) > Signed-off-by: Sinan Kaya > This really feels wrong for two reasons: * device assignment of non-PCI devices is really special and doesn't seem to make sense on general purpose servers that would be the target for ACPI normally * If there is indeed a requirement for ACPI to handle something like this, it should be part of the ACPI spec, with a well-defined method of handling reset, rather than having to add a device specific hack for each device separately. Arnd