public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Xie Maoyi <maoyi.xie@ntu.edu.sg>
Cc: Andrei Vagin <avagin@gmail.com>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: io_uring: should IORING_TIMEOUT_ABS honour the submitter's time namespace?
Date: Mon, 4 May 2026 08:48:11 +0100	[thread overview]
Message-ID: <988f7486-0353-4239-badc-6c0dc9b3abd7@gmail.com> (raw)
In-Reply-To: <aa9ea9e9-dbf3-41b9-874c-1638f454c2d1@kernel.dk>

On 5/4/26 07:06, Jens Axboe wrote:
>> While verifying SQPOLL, I also noticed io_uring/wait.c around lines
>> 230-234. The IORING_ENTER_ABS_TIMER path on io_uring_enter() parses
>> ext_arg->ts inline rather than going through io_parse_user_time, so it
>> does not pick up your fix. Same shape of bug, separate code path. PoC
>> on vanilla shows elapsed = 1 ms, patched shows ~1000 ms. I can send
>> the small follow-up patch for that path as a separate thread once your
>> IORING_OP_TIMEOUT side has landed, or fold it into the same series.
>> Whichever you prefer.

Yeah, I noticed that as well

> Might make sense to refactor a helper that does the time translation,
> and then patch 1 would basically be Pavel's fix and patch 2 would be
> sorting out the io_cqring_wait() translation as well. Both should be
> able to use the refactored helper.

Unless there is some more unification b/w cq wait and timeout requests,
it'll very likely be cleaner to have two timens_ktime_to_host() call
sites, but I haven't taken a look

-- 
Pavel Begunkov


  parent reply	other threads:[~2026-05-04  7:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  9:21 io_uring: should IORING_TIMEOUT_ABS honour the submitter's time namespace? Xie Maoyi
2026-05-02 10:26 ` Pavel Begunkov
     [not found]   ` <TYZPR01MB6758466089A9CAADC5095F20DC332@TYZPR01MB6758.apcprd01.prod.exchangelabs.com>
2026-05-03 15:12     ` Xie Maoyi
2026-05-04  6:06       ` Jens Axboe
2026-05-04  7:23         ` Xie Maoyi
2026-05-04  7:34           ` Jens Axboe
2026-05-04  7:48         ` Pavel Begunkov [this message]
2026-05-04 10:02           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=988f7486-0353-4239-badc-6c0dc9b3abd7@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=avagin@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maoyi.xie@ntu.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox