From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C922C433FE for ; Wed, 2 Nov 2022 11:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbiKBLDB (ORCPT ); Wed, 2 Nov 2022 07:03:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiKBLCt (ORCPT ); Wed, 2 Nov 2022 07:02:49 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8CC233AC for ; Wed, 2 Nov 2022 04:02:48 -0700 (PDT) Received: from [192.168.2.196] (109-252-117-140.nat.spd-mgts.ru [109.252.117.140]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 03B5E660293F; Wed, 2 Nov 2022 11:02:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667386966; bh=Fv2r7VMNMar50Z6R9zjXldd7YfQ7remDoXGGZJmE1fY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iTfgEHH7xgWFBYV5P2ZbTRl4bEU1CphOUG1DTob501Tb5k2XWQuYUhhlZa+eUcCSw XO5MO1ZjaCRLymOol6xtJUxMu4iN/jNsByBFDwCZZTd42mFzySfx2vYEkE+EEi910B SpyS2awJVZ/IkKabCGAamXSoYuB69/VcBi9BptiygpcTSPq+ir3kg325GBvzG8KzBF lKCVsgMv+4ncPFFq4lattwk3BCtTxxtOGrl3zV2ATKHY6EGyM4nsm6PxxgKNu7asfi DOuW+8L29rWVLhLEFv6Hre8cJRkCZ4bJhAZUs9D5QO5rOcBSvTobjMkyrGEonh/A58 FhVQale6x1Ugw== Message-ID: <98b02ef5-2159-5f4f-aa5b-389aba4f92e1@collabora.com> Date: Wed, 2 Nov 2022 14:02:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 2/2] drm/client: Prevent NULL dereference in drm_client_buffer_delete() To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Maarten Lankhorst , Maxime Ripard , Sumit Semwal , Thomas Zimmermann , David Airlie , Daniel Vetter , noralf@tronnes.org, Dan Carpenter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221030154412.8320-1-dmitry.osipenko@collabora.com> <20221030154412.8320-3-dmitry.osipenko@collabora.com> <68dd2e87-c4d6-99de-22bf-5059d03c22bb@amd.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: <68dd2e87-c4d6-99de-22bf-5059d03c22bb@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/22 12:15, Christian König wrote: > Am 30.10.22 um 16:44 schrieb Dmitry Osipenko: >> The drm_gem_vunmap() will crash with a NULL dereference if the passed >> object pointer is NULL. It wasn't a problem before we added the locking >> support to drm_gem_vunmap function because the mapping argument was >> always >> NULL together with the object. Make drm_client_buffer_delete() to check >> whether GEM is NULL before trying to unmap the GEM, it will happen on >> framebuffer creation error. >> >> Reported-by: Dan Carpenter >> Link: https://lore.kernel.org/dri-devel/Y1kFEGxT8MVlf32V@kili/ >> Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap >> operations") >> Signed-off-by: Dmitry Osipenko > > Reviewed-by: Christian König Applied to drm-misc-next, thanks! -- Best regards, Dmitry