The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: sunliming <sunliming@linux.dev>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	dpenkler@gmail.com, arnd@arndb.de, everestkc@everestkc.com.np,
	niharchaithanya@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, sunliming <sunliming@kylinos.cn>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] staging: gpib: warning: variable 'nec_priv' set but not used warning
Date: Fri, 4 Apr 2025 17:15:27 +0800	[thread overview]
Message-ID: <98d40957-1b82-3131-7aea-6c8fe82724e3@linux.dev> (raw)
In-Reply-To: <f6e2c865-7c9f-4301-a1a8-8a5b1dbbb5f4@stanley.mountain>


On 2025/4/4 15:53, Dan Carpenter wrote:
> On Fri, Apr 04, 2025 at 02:08:38PM +0800, Sunliming wrote:
>> On 2025/4/3 22:08, Greg KH wrote:
>>> On Fri, Mar 21, 2025 at 09:06:49AM +0800, sunliming@linux.dev wrote:
>>>> From: sunliming <sunliming@kylinos.cn>
>>>>
>>>> Fix below kernel warning:
>>>> drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not
>>>> used [-Wunused-but-set-variable]
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Please link to where this was reported.  The report from the robot will
>>> have the needed information in it on how to do this.
>> Get it, I will resend the patch to fix this.
>>
>> Thanks.
>>
>>>> Signed-off-by: sunliming <sunliming@kylinos.cn>
>>> As per our documentation, please use your name, not your email alias, on
>>> the signed-off-by line.
>> It's not my email alias,my name is sunliming too.
> Why is it capitalized on your From header on your email but not in your
> Signed-off-by?

I didn't notice that my email and Gitconfig have different names set.  
Thank you

  for letting me know, I will fix it.

>
> regards,
> dan carpenter
>

      reply	other threads:[~2025-04-04  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  1:06 [PATCH] staging: gpib: warning: variable 'nec_priv' set but not used warning sunliming
2025-04-03 14:08 ` Greg KH
2025-04-04  6:08   ` Sunliming
2025-04-04  7:53     ` Dan Carpenter
2025-04-04  9:15       ` sunliming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98d40957-1b82-3131-7aea-6c8fe82724e3@linux.dev \
    --to=sunliming@linux.dev \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=dpenkler@gmail.com \
    --cc=everestkc@everestkc.com.np \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lkp@intel.com \
    --cc=niharchaithanya@gmail.com \
    --cc=sunliming@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox