From: "Li,Rongqing" <lirongqing@baidu.com>
To: Giovanni Gherdovich <ggherdovich@suse.cz>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>
Subject: 答复: [PATCH] x86: move turbo_disabled() out of intel_set_max_freq_ratio
Date: Wed, 29 Apr 2020 08:53:20 +0000 [thread overview]
Message-ID: <98dec9ed285d4f96baccc73195cac84e@baidu.com> (raw)
In-Reply-To: <1588148110.21179.63.camel@suse.cz>
> Hello,
>
> the problem is that turbo can be enabled/disabled by the firmware at runtime,
> after the machine has booted.
>
> This happens for example with the Dell XPS 13, where turbo gets disabled by
> the firmware if the machine is disconnected from AC power and runs on battery.
> The laptop could boot on battery (turbo disabled), then after some time the
> user connects the AC power supply, turbo gets enabled, and with your patch
> we wouldn't know what is the turbo_freq/base_freq ratio to do frequency
> invariance (we skipped reading MSR_TURBO_RATIO_LIMIT at boot because
> turbo was disabled at that timed).
>
> This behavior was requested by reviewers in this thread:
> https://lore.kernel.org/lkml/1906426.HDqaVa71mF@kreacher/
> and implemented with 918229cdd5ab ("x86/intel_pstate: Handle runtime turbo
> disablement/enablement in frequency invariance").
>
Thanks for you explanation
Sorry for noise
-Li
>
> Thanks,
> Giovanni Gherdovich
prev parent reply other threads:[~2020-04-29 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 1:50 [PATCH] x86: move turbo_disabled() out of intel_set_max_freq_ratio Li RongQing
2020-04-29 8:15 ` Giovanni Gherdovich
2020-04-29 8:53 ` Li,Rongqing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98dec9ed285d4f96baccc73195cac84e@baidu.com \
--to=lirongqing@baidu.com \
--cc=bp@alien8.de \
--cc=ggherdovich@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox