From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E41630C37E for ; Mon, 16 Feb 2026 12:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771243712; cv=none; b=ZY9CikHz4JuAm0Kp4L22rO0dy7XGmmPk5Y3cIVhQM0WK0zpjEqg4kZ/PEEEkwLYbOsN+c0ZUi0yXOEyE2c1XQGIv8mWoyTu/B81cDsvMbXXR5ErQLRntVHpBVTJ0pT/PkAlzp6aKBtWKFCUE6+iDFVvMcOkcQuSRVN7F/H3+jjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771243712; c=relaxed/simple; bh=euoa0gLDnWI0VoNYowyLCRHx+WMPWsF+dGMS3EE15JA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WNATnbLU3d0BQT90e3K1gpTge8raAAJVhLOBQhzKO/K5K/K5BTalbwmkO8jJLBXxDhKGpq1CPx1XeCZ6SYzUiaTIDbwhbLKRYQYYpnJ3fIoMwDLpSD/cz13GvyqhxjDOTeeXg3tjSA8M+LnNRNDLHLqmZiNWjaYzCB0Xv4x4w38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WcH5T7Zh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J2jE+ys7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WcH5T7Zh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J2jE+ys7" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61GBBPAk3643128 for ; Mon, 16 Feb 2026 12:08:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h1GocAahT5JsGMvnHw49bX1S/TpbPEB2y5Rax7Pi0OQ=; b=WcH5T7ZhdXQnwe2y TOPVn6cEZQ+Giw57M42K3J+0/v7mRLP58KNT9AZWK5c172myHjjNbj7T3q9LclX/ wRSJ0OfA7yX8SS55rpGMfC+VW5p5Cx5QZyyo02qW4yWx9cwBkvysPaHp/zcEFNaw +1vNGfuUfCMBGGYuS2umjPOnE6hKGw0iUync1aePfcG5KBpcTg9yD4CquE7kRj3e o4cByDvHm9lSbMY5ivDUbbl1Oc2mtByo8crUtutkYhjmt3kT7w4qZe5hgFKcT37L bUgegdDor6qy2d0fdp2sGLFf1/romM35PAu0rie5LqOtnGJd9xAi3lrV9M0uHy0S tyWHDQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cag24cgk7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Feb 2026 12:08:30 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a7b7f04a11so165360645ad.3 for ; Mon, 16 Feb 2026 04:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771243709; x=1771848509; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h1GocAahT5JsGMvnHw49bX1S/TpbPEB2y5Rax7Pi0OQ=; b=J2jE+ys78wn/z4cPS/+YUQ7fCfqvD7BRxNWPnE0acSAlQCboZ+011ORM4v3FVe+XNe mLN2fM6nAVroViqgQx+EgxlBK7203ax+7/5rA775XH2gzOx0kwkRnQ6hxthBxhxEVBh6 McmERtwn1/09Dpa/7BtInrJ2grdYFkbUa7csK2vLOj8lUdjj0T4HR7/FsUFvtGsT8bzw J4givFz+a7RGerQ6eoTRaELBtOr16+YjT0ZhiSqYGL3sFO4Lq4iAxqOYFd3KOCjEK5s1 lcJAp2bIEIQ43gYbrOAtyewkrSAIjbHs52Tm8sb0guDvH5+3oq2aicULSr4uSnNpGyQF VzNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771243709; x=1771848509; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h1GocAahT5JsGMvnHw49bX1S/TpbPEB2y5Rax7Pi0OQ=; b=Xz+3XUrjcHJkpASbasDyKkv81LeUu6Ygn8sfz1+SMK410UVf04yZ6aLB/gQczRRECf MDP2Y3iES/rw8HclzzOu5RqzN36uGbiP5cJbonT9OqSugJsnzpLd2H19RUUeSaV7YY6D KkrI45af/tgHSJLZTkhkhRDLcGNPjanJQW1DRGfL1qw3snhpH0NEgdkNsxLOALE8CSg8 CuFN+FEgeSaruhgu8y5lVLlovupN0y1ev1qcqfOyzviKqBEJ1r2aHMwB/b8H2+jCQLaa V1uJfbn0VO/TSs3RqYNC/9uEGNN8gR0rCUdE5pCk/pbMtt1N8Aq34R4oLY93iU/9RsHQ P+rQ== X-Forwarded-Encrypted: i=1; AJvYcCWuacz9lAk7ySH/UPoJyzho9AZiP2T350dJhZs4HQwzy3RNWqeyQDn7nqhMjXPpQ38g6cU2t14ZUHjJLbE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt8byLnQfbUOfwT038sm0JeCwysNoKlt238nyNaLPqCEYf1Hsa bMQpSOzgHsiZutt9bxKhWe2cotu4CTjqUV/YIj2QZCzbHrByIntzf2H5+NT2s2qb1n8S47JDFJB M/tIpZen7/PDDmneYtKAE1WQGONxWeapaosxQDo3ka1rHoPSXwAl1EGRrYSqQ+lmoqxs= X-Gm-Gg: AZuq6aLQGRVh6QZPGomZpQ3eNHwHIfSoE3CtkPuE0BLfkHfh6LfSIjvpgDsoeoWbkPf RXKxfUbb5kap+UEten7EO7lw4aczwcZkTcQerH8lfSc2gf/jftRtj+XPDN7W6ca0MFVSFvIyEOI 6XnraZmNoqn52XNYiQRKfhFmfdQttGaXwBimgtSHmF1iAeGor0+QEzCG2vteEQAGZjRuNTyh2L7 n5eHcyv+jihkyx0lodrSOhfPzh96hfjo4UXVOWjJrX0KLpoJ9sg0UreD2F9YH2O2cWleFhrgKW9 egjdOhte/flsyddeYE9p03v/jUq2ffwGYNHPSqdGHdCYrpmkImyQxINoNnWS8YMkenPY+swtL/l J/t1dHF8KX7GWscXs31xsWDEEX4lL7KNzMPpYiumwJWmEzL+53qE= X-Received: by 2002:a17:903:41d1:b0:2aa:f0d6:bf59 with SMTP id d9443c01a7336-2ab50598d15mr109345005ad.35.1771243709174; Mon, 16 Feb 2026 04:08:29 -0800 (PST) X-Received: by 2002:a17:903:41d1:b0:2aa:f0d6:bf59 with SMTP id d9443c01a7336-2ab50598d15mr109344645ad.35.1771243708735; Mon, 16 Feb 2026 04:08:28 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a6fa34bsm64774895ad.19.2026.02.16.04.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 04:08:28 -0800 (PST) Message-ID: <98eab1bd-9177-4c92-8fdc-1ff35d020c79@oss.qualcomm.com> Date: Mon, 16 Feb 2026 17:38:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: defconfig: Enable QCOMTEE module for QTEE-enabled Qualcomm SoCs To: Krzysztof Kozlowski , Kuldeep Singh , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Sumit Garg , Jens Wiklander Cc: Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20260114-qcom_qcomtee_defconfig-v4-1-ec676311171f@oss.qualcomm.com> <91ccacf3-68cf-4bfe-879a-db515a6732ec@oss.qualcomm.com> <804c0c03-d461-4fd9-ad0f-be123b3f1798@oss.qualcomm.com> <7d4006b0-8fcc-4e31-abfc-98ca8bf3bc2f@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <7d4006b0-8fcc-4e31-abfc-98ca8bf3bc2f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _CwUruNasK0Z7fANu0I5r70iV8xGNR60 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE2MDEwMSBTYWx0ZWRfXwjqAOZzgPCPa fQnO5nZekyXEtHf/0y14cYAzzn1blSaW5VKApQOKd3mtnY57OrvD9KBVcu8kkkkye+bd6ayIrj4 ZOfg9Nk6Y/iTNAE1ifxcNL10WnyW+vnuTdUnaB8MYaf17qkodu401RwkdxvR1P37Tp61LzXiAK0 KKrJlsqVox8oy0wIYTFvB6SWmxwnFbv9cwDagXtQKDG3IK26f3NQmjQYFA4d9tTjWrL65+lu4HP j7XkO4kFsxmR60ZXNFXA3okQmEGFIsDyJwdT5x54Uet+Y1EVlTuaf7+31Aua7XuK5H3XQZ52gXE 8enA0zMWgSIc4trVcwKn+YXRREoAq/fftsjm7lIqWZgPeVYSEnPxFoxsttpKtHj61zcg6gJYmPt XBzCkc729wzeYrYUNYiJiXPLoL3/uNysb6G7g9mpFdUwnFPezNE7Y36k2ZOGTK7Ubtp1FczFN9C Kng9U3vE0Zen5SLvsEA== X-Proofpoint-ORIG-GUID: _CwUruNasK0Z7fANu0I5r70iV8xGNR60 X-Authority-Analysis: v=2.4 cv=aetsXBot c=1 sm=1 tr=0 ts=699308be cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=2EOIg3pBiIC1XDWYfRIA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-16_04,2026-02-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602160101 On 2/16/2026 4:09 PM, Krzysztof Kozlowski wrote: > On 16/02/2026 11:36, Harshal Dev wrote: >> >> >> On 2/16/2026 10:48 AM, Kuldeep Singh wrote: >>> >>> >>> On 2/13/2026 3:56 PM, Krzysztof Kozlowski wrote: >>>> On 13/02/2026 11:24, Kuldeep Singh wrote: >>>>> >>>>> >>>>> On 1/14/2026 1:49 PM, Harshal Dev via OP-TEE wrote: >>>>>> All Qualcomm SoCs starting from SM8650 provide access to the Qualcomm >>>>>> Trusted Execution Environment (QTEE) through the SMCInvoke interface, >>>>>> implemented by the QCOMTEE driver. QTEE runs in the Secure World domain >>>>>> on ARM64 CPUs and exposes secure services to Linux running in the Normal >>>>>> World domain. >>>>>> >>>>>> This change enables the QCOMTEE driver as a module to support >>>>>> communication with QTEE. >>>>>> >>>>>> QCOMTEE has been tested on a Qualcomm RB3Gen2 board by loading and >>>>>> executing a Trusted Application via tests hosted at >>>>>> github.com/qualcomm/minkipc. >>>>>> >>>>>> Signed-off-by: Harshal Dev >>>>> >>>>> Tested on rb3gen2 device and able to see driver load successfully. >>>> >>>> What exactly did you test? That a module can be built? >>>> >>>>> >>>>> root@qcom-armv8a:~# lsmod | grep qcomtee >>>>> qcomtee 32768 0 >>>> >>>> Sorry, but that's basic of kbuild and module system. >>> >>> Yes, did a basic testing only. >>> >>>> >>>> >>>>> root@qcom-armv8a:~# rmmod qcomtee >>>>> root@qcom-armv8a:~# insmod >>>> >>>> Not a defconfig testing. >>>> >>>>> /lib/modules/6.18.0-next-20251202-00002-ga8c3ce157925 >>>>> -dirty/kernel/drivers/tee/qcomtee/qcomtee.ko >>>>> [ 164.464598] qcomtee: QTEE version 5.2.0 >>>>> root@qcom-armv8a:~# ls /dev/tee0 >>>>> /dev/tee0 >>>>> root@qcom-armv8a:~# >>>>> >>>>> With that, >>>>> Reviewed-by: Kuldeep Singh >>>>> Tested-by: Kuldeep Singh >>>> >>>> You cannot test a defconfig. >>> >>> Sure, we can drop tested-by tag. >>> Maybe patch author once send next rev can just add Reviewed-by tag only. >>> Hope this is fine. >>> >> >> I am fine with us dropping this Tested-by tag. I thought it made sense to test that >> the driver being built as a module is removed without encountering any issues. > > We do not talk about this. No one claimed that this test is good or not. > Read again discussion - there was no test of this defconfig change. It > did not happen as it cannot happen or is completely pointless. The tag > applies to THE COMMIT not to something else. I explained this way too > many times. > Understood. Thank you for clarifying once again Krzysztof. Regards, Harshal >> I will not send another patch revision just to collect/drop tags. >> >> Thanks, >> Harshal > > > Best regards, > Krzysztof