From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2F743DA28 for ; Mon, 18 May 2026 12:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108588; cv=none; b=c16EaDjZyw5PTo2TLzamDitvG8SYl2b2yZ2syZ5FfrzFJYaCbWtGKOLTuPSfkGWf7UJb/U2iPHY28y6DPeSOx0iIAGhtEFmcIsX0zKiv3IHaV6ckv2zmcVUVWi4+kN7DxZ8dAL0M0TOd4S1kYLuVfqejjxvl71/r3/HiWrFrpCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108588; c=relaxed/simple; bh=VX8+7teOpuLOnW4ObAqFfBxsvvas9Rw3iPUKhD4heaM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aLpVXQ+K94eQ7FIvdZTAV7RK0T/lINNU8Os6vDhPnYDmN3YiJHO5rwlW/awDJLch7PBca/RGlp9jexCIk4/Kcpg6Fxo32HhDrNxt6ypBGRd3Mz5kNld3Pa37gO4ar/dsqfuYDu3bHez2ggWQVFglaRORhs7c/Kvh0ZQ6Olall10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lP5GH9Rv; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lP5GH9Rv" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43eb05b1875so1174661f8f.3 for ; Mon, 18 May 2026 05:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779108583; x=1779713383; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bLINeqKl/XpuS1gQDX5t3BFzlGZzG1IUU9h1YDvpHyU=; b=lP5GH9RvQxzbBgCglfFTLZdX6CpPKqP8SDhIYRQFK+Mk7jQ5MQgt9AwmpgLlGSerN6 o/tDU5b1WCSjtk5qYGTryMXUcbXUwOfqg0W4gT0gBUMkcLIi9BYR9zFb6McVsm72vrNE oCr/n1a61yxWlE4L3j+WV7S2yLaagmSNTxbDfp7pqhPpLoOq8NNwVJo1Zus+cZymJLJQ JjiPasiWEDa8qvH51cqcF4Fbn0lCNzrSk8DwxKrzuUp3lIvqVqQSu+/aJOluuMleKPiq 0K3xNhuh6oI7BPO8Br8RQnCo4YbTIE8Py+adknCUJLOB9E64hzgoM4nnl+ZF1WwhxlrY 3Lug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779108583; x=1779713383; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bLINeqKl/XpuS1gQDX5t3BFzlGZzG1IUU9h1YDvpHyU=; b=Mb7L/HbF3chuFcotRkmuyE31rvRCUXEloXlj92bQ3H2GoWqGXM6/iV+rs8YwDcO4DN 96lYd0vss/9tMfJqDJT57dNK72MlnBmTuvK+NqHlgjcwFy/r/SBzWbEY7tqjJqIxFICF p0U9J3FBhb9Qe6nXoRv6PlJEqlLE/la6vGdSKzHHY8FA1SrspgFRNJkmX87qhzX5MUok Xpc/heyfq0iUed0fplr55D2whOlt2nP2bpMVCWRvQlP8gN5r1zgx5WwAyT9AnOVHMrYi iKJ/EOqUwsCkA4rvqdtdfIYB6k1AkjjMXLCFO+ZZkOC/Wotmj9BYg7eYd/Yj1z+gWJjR A/QA== X-Forwarded-Encrypted: i=1; AFNElJ8JoMaYSN++vQq/IULZtqc4LAq/E+WspzPTuwbsrKZL4n7inD69y4IEz3dAzBF5WsXPb/e6yVwQqsOuIzA=@vger.kernel.org X-Gm-Message-State: AOJu0YzV/mhTHABRGnga7Euw7wEUpRr+C2JjoSXhOjj694gxKONc1oQo /PH98J2sexeAttrejkNJw0BdbqXhDFqDfbzg5+0e7ZV+8Z/LMJ4p2CM57Zcw0jhS X-Gm-Gg: Acq92OG5UB4vixx7g3qUEImYPgoiKRSOJDgbtLY4D/Ms4o/gTlMZLigNTChJxe6eCBu 3yg1ovmmfLHtR9uxKjg8wKAlIz+K44Wg99+UcsJ5eg+Ybjaa7tKoIF+j53rmOqMwS36VFPpsw4m OgqEmGmBtdcsBL6lDjDC/a13CW5G6/obaqjqRCKUJt9YSb6SC1At26OxZynK8Qi9mg5QvjEWicq XPlZEn6ZrKqXfjGd5bo6ZX0r+b3ZLvvfmtRJ8Pw2KlkIFkl+uN8Z15VX+1YwJyY698DIY+hk7/p c/QhqDMq7fi96obMIFqc2m74jMDFr8CFr0qObh9nZhHEN9GcIuaxhHK2N6YlpfsN7lx49OAAc9M g1kix8pusiSuLlQ6TQtz3QIQrI008/lVF2mxkpDUGXCcEJGgEo/GvevxQhMRYaSHFr3yDGZ5K1p t4bwtZhEOIZgqP1nRylR4CctSRj3x2hhXnNdV8Uz8= X-Received: by 2002:a05:6000:290e:b0:43d:7b90:fa23 with SMTP id ffacd0b85a97d-45e5c6019bdmr23079609f8f.29.1779108583125; Mon, 18 May 2026 05:49:43 -0700 (PDT) Received: from [192.168.1.220] ([176.74.141.242]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19c2dsm38266667f8f.21.2026.05.18.05.49.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 05:49:42 -0700 (PDT) Message-ID: <98f9f0e3-964d-414c-a329-254c141c8d48@gmail.com> Date: Mon, 18 May 2026 14:49:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] dm-inlinecrypt: add support for hardware-wrapped keys To: Linlin Zhang , Mikulas Patocka , Eric Biggers Cc: Alasdair Kergon , Mike Snitzer , Benjamin Marzinski , Neeraj Soni , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260516115045.3958326-1-linlin.zhang@oss.qualcomm.com> <20260516115045.3958326-2-linlin.zhang@oss.qualcomm.com> <3b57685a-09b4-473a-8810-bbb46769ab42@gmail.com> <2712f864-0f68-4428-9ba5-55fbf35de6e8@oss.qualcomm.com> Content-Language: en-US From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: <2712f864-0f68-4428-9ba5-55fbf35de6e8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/18/26 10:11 AM, Linlin Zhang wrote: ... >> IOW the mapping will look like this (1 is number of optional parameters): >> >>    1 hw-wrapped >> or >>    1 keytype=hw-wrapped > > > Thanks for your suggestion! > > I agree that keeping "hw-wrapped" or "keytype=raw|hw-wrapped" as an optional > argument helps preserve compatibility when switching from "crypt" to > "inlinecrypt" Just use semicolon as separator as Mikulas suggested. (I mixed that up, we always use semicolan as separator.) > My concern is that, in practice, this optional argument may effectively become > mandatory for certain configurations. For instance, "hw-wrapped" or > "keytype=raw|hw-wrapped" must be set for a wrapped key. This slightly blurs the > original intent of "optional arguments", which are typically expected to be > truly optional for correct operation. It no longer works this way, it is normal that in some scenarios "optional" arguments are required. For example sector_size - once you use non-default, you have to specify it always. IOW no problem with that. Milan