From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Avraham Shukron <avraham.shukron@gmail.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: omap4iss: fix coding style issues
Date: Tue, 31 Jan 2017 12:46:51 +0200 [thread overview]
Message-ID: <99077677.ouMsYN1JNl@avalon> (raw)
In-Reply-To: <20170131104251.GU7139@valkosipuli.retiisi.org.uk>
On Tuesday 31 Jan 2017 12:42:51 Sakari Ailus wrote:
> On Mon, Jan 30, 2017 at 07:47:40PM +0200, Laurent Pinchart wrote:
> > > @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh,
> > > struct v4l2_selection *sel) if (subdev == NULL)
> > >
> > > return -EINVAL;
> > >
> > > - /* Try the get selection operation first and fallback to get format if
> >
> > not
> >
> > > - * implemented.
> > > + /* Try the get selection operation first and fallback to get format if
> > > + * not implemented.
> > >
> > > */
>
> /*
> * Multi line
> * comment.
> */
Then let's patch the whole driver in one go :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-01-31 10:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 18:00 [PATCH] Staging: omap4iss: fix coding style issues Avraham Shukron
2017-01-29 7:31 ` Ozgur Karatas
2017-01-29 22:42 ` Avraham Shukron
2017-01-30 17:47 ` Laurent Pinchart
2017-01-31 10:42 ` Sakari Ailus
2017-01-31 10:46 ` Laurent Pinchart [this message]
2017-02-06 17:58 ` [PATCH v2] Staging: omap4iss: Fix " Avraham Shukron
2017-02-07 8:12 ` Greg KH
2017-02-07 15:40 ` [PATCH v3 1/2] staging: omap4iss: fix multiline comment style Avraham Shukron
2017-02-07 15:40 ` [PATCH v3 2/2] staging: omap4iss: fix coding style issue Avraham Shukron
2017-02-09 11:06 ` [PATCH v3 1/2] staging: omap4iss: fix multiline comment style Greg KH
2017-02-09 16:57 ` [PATCH v4 " Avraham Shukron
2017-02-09 17:01 ` [PATCH v4 2/2] staging: omap4iss: fix coding style issue Avraham Shukron
2017-02-10 7:48 ` [PATCH v4 1/2] staging: omap4iss: fix multiline comment style Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99077677.ouMsYN1JNl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=avraham.shukron@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox