From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ben Zong-You Xie <ben717@andestech.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ukleinek@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: add atcpit100-pwm
Date: Tue, 3 Dec 2024 08:17:13 +0100 [thread overview]
Message-ID: <990b0efe-0018-4910-910a-8d1431ea26d8@kernel.org> (raw)
In-Reply-To: <qmbaftzr4ww35txfjvt6iao5g5jjikx5swgh6cdqbiu36dwo2y@74vnlk2a3ihn>
On 02/12/2024 08:40, Krzysztof Kozlowski wrote:
> On Mon, Dec 02, 2024 at 02:01:46PM +0800, Ben Zong-You Xie wrote:
>> Document devicetree bindings for Andes atcpit100-pwm.
>>
>> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
>> ---
>> .../bindings/pwm/andestech,atcpit100-pwm.yaml | 51 +++++++++++++++++++
>> MAINTAINERS | 5 ++
>> 2 files changed, 56 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml b/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
>> new file mode 100644
>> index 000000000000..4b707f32ad72
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/andestech,atcpit100-pwm.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/andestech,atcpit100-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Andes atcpit100 PWM
>> +
>> +maintainers:
>> + - Ben Zong-You Xie <ben717@andestech.com>
>> +
>> +allOf:
>> + - $ref: pwm.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: andestech,atcpit100-pwm
>
>
> Previously, before we removed it in 2022, this was just
> andestech,atcpit100, so questions:
>
> 1. Why are you re-introducing it? Please address all the comments or
> aspects leading to removal.
> 2. Why are you using different compatible? Is this one device?
For some reason you replied while removing most of the people from
address list. That's weird. Don't change the recipients list.
All my statements are still standing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-03 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 6:01 [PATCH v2 0/2] pwm: add PWM driver for atcpit100 Ben Zong-You Xie
2024-12-02 6:01 ` [PATCH v2 1/2] dt-bindings: pwm: add atcpit100-pwm Ben Zong-You Xie
2024-12-02 7:40 ` Krzysztof Kozlowski
2024-12-03 7:17 ` Krzysztof Kozlowski [this message]
2024-12-02 6:01 ` [PATCH v2 2/2] pwm: atcpit100: add Andes PWM driver support Ben Zong-You Xie
2024-12-02 11:50 ` kernel test robot
2024-12-02 13:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990b0efe-0018-4910-910a-8d1431ea26d8@kernel.org \
--to=krzk@kernel.org \
--cc=ben717@andestech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox