From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77D4713B2A4 for ; Mon, 8 Sep 2025 07:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757315849; cv=none; b=VzsjgaFqHPWcJPdS67z2Rn9Wsu4OTE9oHP+B+a1n8kqMas+sCaY3VK71rC7IpPn+uD5WOBRrG5i/NYQj8jVb297rbISpePxXD0Srg0WlH4AOZoF2gPTnkw/M+dAt4NMrizn4Bde94S0QdU11WzHkrx6CzdCxfZ1qAvDq9RKA5Ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757315849; c=relaxed/simple; bh=n+aaWyQRYIu1MksN7mzgmu/sMhs7wreA4Hz4TnVNjRk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wsb1U2ojM0vHH4bAk9uTvrJp07UBs5FgZaFvbKx7xVt5meKN0f44L9Wzs6ppm04nWt0ICHRricAWlneaTVMuZsd/X7DvzAqvA+0HHGHeMeo25jHIfbedfHkciK8OGkwoT5/jQbByo3/6eiaPRJXtHRaPL9k+4WLjRKxVU4wyE9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CGswnwMY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CGswnwMY" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 587LuMgD029406 for ; Mon, 8 Sep 2025 07:17:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GvkSbj34UnoKQWHt/fvkvc/27oZE/6107qizJVFFrps=; b=CGswnwMYlYbkOmkz qSixhdi9F0RQA8Bkp08rMOqS12FzgoXt849zIok/XJ/wnMrDJ7BOHZ2pwNXHmRrm GHBL0B7u+wtmsgQlPT18RxJg6vyn9ZsMVoAqLAOFCXpZPyVWo7k3fv5Y0Hbryga/ YeIjp8kIzM/astALJQfbMoBN+vvnE+A34rjDCuWC1Ve4YKK+ACvL9kzqQwR6ujs6 VMfEHL8iDK6/JwPVvBrk1DNakvJ0tG8gxGp9HCPMXLyl4dl5kwDyoCZSUMyOJ789 9l7nVCFYaHA8yH6lggruU3f02SXsugJZiFeKhwxo9CW0VmJx/t07JIV8nUog+CWl MRLang== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490by8upmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 08 Sep 2025 07:17:26 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b604c02383so6875991cf.2 for ; Mon, 08 Sep 2025 00:17:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757315844; x=1757920644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GvkSbj34UnoKQWHt/fvkvc/27oZE/6107qizJVFFrps=; b=K4xnDpFqH8fM8M3QhBW/54fv/D/h9F5Wjfq5Pk38wGuwFtBZJkYO9Lvo0CpYNXOluE wmXPz//Z6z91XM4vOvs71e/FMALxLSoij3K0ujHd0v35+8WXTnCy4MHY+nqV/JgwfnM4 RHq53LwOAi2uffK2D2UVD7ORxET4I4BRB1hClFYzBS9jIpojt75zFuC0XCyl/5ef6yqJ cYPzatPTtqbpojkI2YZPpQeZJiX8OTkhyCoWB5mor8QJ23PpapwveEHmmwTHGaAV9zu6 tLT+1LCd2flmlvo2uM0wQ9BISg33AfONymwp0zu22bTxCacw8wN4tNTTYMcowXjRWBd2 nOyQ== X-Forwarded-Encrypted: i=1; AJvYcCVJXMQaeHIvD0QOIwFbZiuVkreMzx/Tns54eRuHJouxVzgJOqPv1WMVpOQZCpx9R+UhIsONJ98FpGAGOW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yylbw+9OWc3b89HQVJ5NY2Pf/+MI+KF8uyeQJrkqILbvdD8mzgv UghXabDa1vBRYMRRKyM3AVxDsNVVKg8xYq+/zR4btoRKENx3keDvEEUxAGNGA0tQcnK0MaxROC5 D0+jz2woVBpQQikcsMg8Tz6cKqn5z48gyZnqUzqFJ93mK2My2BsYOHBKDPOcF6oyNYyE= X-Gm-Gg: ASbGncu5hayH6piK4RX8ObU6nEBLsTBU/25gjY3aapKro4n+C8Ju8YyREN0Gzebxa6T 40m3YGAhSa1MqFg7JRcZ4myTjj8RRLuaHXEOT8yw/Ns3XZOG17j8oPWSSwSB2YwO0vc2Zgl55KI b49GLlhbT40Xf93EFsZ9JMjUgbo8LInEthGvwfAyM1I7YmYaYTfkBd6F3h/XEVL8e/BZA7k/iMG A0bmuMnQn1aBJb03lNMa5tHSzlBi+N3l1Mjy9M+Viu3XKj6sUTH4Vii4OgMej2oRwRzBC7Y7Jy8 vsEom6UyP5HLCDWQPA7xVHZm5ZP7gs2zXCawzuXB6ycSpb0lwrMvHyd8l6lusamDtKKCfkHs1VR qqY2aiez9L/kMCjWTyGJKBA== X-Received: by 2002:a05:622a:24f:b0:4b5:f066:13d0 with SMTP id d75a77b69052e-4b5f83da97fmr52185611cf.6.1757315844110; Mon, 08 Sep 2025 00:17:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcOPchr9S1m9Rz4KxpIgTUicCH7autfYrV7AOUqW7HOqK6Yy6+QlEA3QyM4wlHT62r+3EMIg== X-Received: by 2002:a05:622a:24f:b0:4b5:f066:13d0 with SMTP id d75a77b69052e-4b5f83da97fmr52185381cf.6.1757315843423; Mon, 08 Sep 2025 00:17:23 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62343271613sm5088615a12.23.2025.09.08.00.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 00:17:22 -0700 (PDT) Message-ID: <9923f086-9deb-4d3f-813c-7d9b94c7dfdb@oss.qualcomm.com> Date: Mon, 8 Sep 2025 09:17:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 3/3] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: add HDMI nodes To: Jens Glathe , Neil Armstrong , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250821-topic-x1e80100-hdmi-v1-0-f14ad9430e88@linaro.org> <20250821-topic-x1e80100-hdmi-v1-3-f14ad9430e88@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Yv8PR5YX c=1 sm=1 tr=0 ts=68be8306 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=4LzuJVVA2EB8z9vYX0EA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: OqbLVOqTw_TH4dfr2PMb2uzPH2VVWwlo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAxOCBTYWx0ZWRfXxHM4nMPr7VzR 3Igfn2IC6j6avPQK2rqWWRJmtTsrS6qWbZQeL3W4uC3We3sjJuZLeAlOuEKYsnijMh6IRufGiUe SkNnsU95xgo04Wh2mQ+Giw9MOC/ceq1w2sT5ZBY0QvZ39Nz2SCVyu6fVPuOg19KNB0oU/QzbgKk 4FV6jFC/E1vwSTRS1mpXsPlS37UXoGHOIc8hld/qJmYgE/nm2NT2yoS9IJLkS2IKOfHi6/JHdxl GYhC5TaNTh4IZwMr3OlZh0XqbVkgFRkwJ8vze4CO+2La1f4dFFsmiPaorLMiUZB/eNVtBUx0owW pKfFspT8yRPafX3OUE8p9kfloRhYeBab7mK426dKg/DFLshT662Hj3D4bBJ5KQl48eImTBtzH/k FG+JBuUP X-Proofpoint-ORIG-GUID: OqbLVOqTw_TH4dfr2PMb2uzPH2VVWwlo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-08_02,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060018 On 9/8/25 9:16 AM, Konrad Dybcio wrote: > On 9/6/25 10:41 AM, Jens Glathe wrote: >> On 21.08.25 15:53, Neil Armstrong wrote: >>> The Thinkpad T14s embeds a transparent 4lanes DP->HDMI transceiver >>> connected to the third QMP Combo PHY 4 lanes. >>> >> [...] >>>   .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    | 44 ++++++++++++++++++++++ >>>   1 file changed, 44 insertions(+) >> [...] >>> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >>> index 4cf61c2a34e31233b1adc93332bcabef22de3f86..5b62b8c3123633360f249e3ecdc8ea23f44e8e09 100644 >>> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >> [...] >>> +&mdss_dp2 { >>> +    status = "okay"; >>> +}; >>> + >>> +&mdss_dp2_out { >>> +    data-lanes = <0 1 2 3>; >>> +}; >>> + >> >> Hi Neil, >> >> shouldn't mdss_dp2_out also have the link-frequencies property? >> >> +    link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; >> >> Or is it something the bridge already negotiates? > > No, it seems like our driver falls back to HBR2 (54xx) ever since the > driver has been made aware of this property: > > commit 381518a1677c49742a85f51e8f0e89f4b9b7d297 > Author: Kuogee Hsieh > Date: Tue Dec 27 09:45:02 2022 -0800 > > drm/msm/dp: Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint > > Dmitry, is there any reason not to allow HBR3 by default? Is our dp > controller/driver not smart enough not to advertise rates it can't > support, during negotiation? I suppose if I want an answer from Dmitry, it would be fair to add him to the recipient list.. fixing that Konrad