From: Jeff Kirsher <tarbal@gmail.com>
To: dwalker@mvista.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.13] Warning in the e1000 driver
Date: Thu, 1 Sep 2005 16:45:31 -0700 [thread overview]
Message-ID: <9929d2390509011645346ef612@mail.gmail.com> (raw)
In-Reply-To: <1125603508.4867.24.camel@dhcp153.mvista.com>
On 9/1/05, Daniel Walker <dwalker@mvista.com> wrote:
>
> This should fix a small warning in the e1000 driver. It casts to the
> largest possible type dma field. This was found while compiling for
> X86_64 .
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.13/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- linux-2.6.13.orig/drivers/net/e1000/e1000_main.c 2005-08-30 18:28:41.000000000 +0000
> +++ linux-2.6.13/drivers/net/e1000/e1000_main.c 2005-08-30 19:42:45.000000000 +0000
> @@ -2767,7 +2767,7 @@ e1000_clean_tx_irq(struct e1000_adapter
> " next_to_use <%x>\n"
> " next_to_clean <%x>\n"
> "buffer_info[next_to_clean]\n"
> - " dma <%zx>\n"
> + " dma <%llx>\n"
> " time_stamp <%lx>\n"
> " next_to_watch <%x>\n"
> " jiffies <%lx>\n"
> @@ -2776,7 +2776,7 @@ e1000_clean_tx_irq(struct e1000_adapter
> E1000_READ_REG(&adapter->hw, TDT),
> tx_ring->next_to_use,
> i,
> - tx_ring->buffer_info[i].dma,
> + (unsigned long long)tx_ring->buffer_info[i].dma,
> tx_ring->buffer_info[i].time_stamp,
> eop,
> jiffies,
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Just remove the following lines
> - " dma <%zx>\n"
and
> - tx_ring->buffer_info[i].dma,
from the DPRINTK statement. The information being provided for debug
purposes is not that helpful when debugging anyway.
--
Cheers,
Jeff
prev parent reply other threads:[~2005-09-01 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 19:38 [PATCH 2.6.13] Warning in the e1000 driver Daniel Walker
2005-09-01 23:45 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390509011645346ef612@mail.gmail.com \
--to=tarbal@gmail.com \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox