Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB

Jeff Kirsher
2009-11-20T19:16:49Z

On Fri, Nov 20, 2009 at 11:13, David Miller <davem@davemloft.net> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Fri, 20 Nov 2009 06:24:21 -0800
>
>> On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput
>> <jaswinder@kernel.org> wrote:
>>>
>>> tc is required by CONFIG_IXGBE_DCB.
>>> This also fixes compilation warning:
>>>
>>>  drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_tx_is_paused’:
>>>  drivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable ‘tc’
>>>
>>> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
>  ...
>> I just submitted a patch to fix this.  So NAK.
>
> But his is much cleaner that your's, less ifdefs.  I think we
> should therefore use Jasdinder's version.
>
>

:) That is fine. The end result is the same.

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

--
Cheers,
Jeff