Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB

Jeff Kirsher
2009-11-20T14:24:17Z

On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput
<jaswinder@kernel.org> wrote:
>
> tc is required by CONFIG_IXGBE_DCB.
> This also fixes compilation warning:
>
>  drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_tx_is_paused’:
>  drivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable ‘tc’
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index ebcec30..61a02ce 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -242,11 +242,11 @@ static void ixgbe_unmap_and_free_tx_resource(struct ixgbe_adapter *adapter,
>  static inline bool ixgbe_tx_is_paused(struct ixgbe_adapter *adapter,
>                                       struct ixgbe_ring *tx_ring)
>  {
> -       int tc;
>        u32 txoff = IXGBE_TFCS_TXOFF;
>
>  #ifdef CONFIG_IXGBE_DCB
>        if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
> +               int tc;
>                int reg_idx = tx_ring->reg_idx;
>                int dcb_i = adapter->ring_feature[RING_F_DCB].indices;
>
> --
> 1.6.5.3
>
>
> --

I just submitted a patch to fix this. So NAK.

--
Cheers,
Jeff