From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE4333C518 for ; Tue, 25 Aug 2026 16:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787674745; cv=fail; b=Kvvkc//rlpqGqNSdBLzi3w+R73Ac/9GzDMnuXSFOeIp1HRLYu+PjpEowLqFBTTA9PQBWys4uTBRpmhlnpQ2fBT8ys9FsMF9+h8xYm4uGwefyw5RWImgR8aZ9Bwh6TyaYKVWt/NxRacMYcm85v7WSfLBVAR0Poz1jhvHQ9gAvEpw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787674745; c=relaxed/simple; bh=3YTzRz0/UuvPnzDghRuWeuuekJHOrPHWrcerSLk6vsM=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=kAKLJzNSn8ZeuaQD3lmplBzPBk8MrZaDSOdwl6W294hd5xEjnaFqk4TzW9Uxg402yS3hzKV3FrPmyuqIZcvCs3cCLitXdVnr6V3YavCF6Xvzfpd/4xMJ/hkasYoxrwiFpLHWYckx9j2xKEXLGjeVV4VyVcFHohPQcd7WDH+RFvM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S7o0hUg5; arc=fail smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S7o0hUg5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787674744; x=1819210744; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=3YTzRz0/UuvPnzDghRuWeuuekJHOrPHWrcerSLk6vsM=; b=S7o0hUg5iM+k+iqT/FbXWMipOSFZNOnQ5gvjBwuHDjKaYrE06+pE54Ry 7UDBZANWU6qu77ZyJ5CW+XPTQixyVOUv0PORVtt6Ly1DA0epKbMZCx46F KjymjPHlWFfKgapoFp/NbNm8YNTBweTWN9LmWwzQDoj1Hr0Tse86pWA6f 6W/bzTwHMeIopEnvwIHmS3S60ehfk30xFWRcnNKvz9eX2UAD/PV/Fndx+ Suz1UyXE6xVHHQOvOSrnmTo7U894rupx83MgVPhfPQIW23dHeDfxdUFKH 8l/xZ2/waNONAlkX2qJl8H2ZCLMviu/wAQ/1plnavtdvikTabtw3oPl1w w==; X-CSE-ConnectionGUID: sK4vJR4kSo2gtiYFUO9z2w== X-CSE-MsgGUID: YJ7Bc7UOQ5ayd+imRAdR7A== X-IronPort-AV: E=McAfee;i="6800,10657,11886"; a="87274479" X-IronPort-AV: E=Sophos;i="6.25,243,1779174000"; d="scan'208";a="87274479" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2026 09:19:03 -0700 X-CSE-ConnectionGUID: 4e0me1reRCmoj0leFYmwoQ== X-CSE-MsgGUID: pLhEDfi/Q86YA97360ZBOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,243,1779174000"; d="scan'208";a="297241043" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2026 09:19:03 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 09:19:02 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 25 Aug 2026 09:19:02 -0700 Received: from BL0PR03CU003.outbound.protection.outlook.com (52.101.53.36) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 09:19:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KhKAU4F8bJ6CfwSrtm3U/QYIOncQTqyZGMv/oiIRKs9In/gwY2lBSxc/AZfxoDE434Hj6Qg2X41z/IgagTlrjcS5i5phXxx0uHECQ9S2Qxzn1moY9gDAo7pbcyHYrcnVMm+9RmDHypG9u41UmJs8vjUX6tO2XjrAd8aoC2xWqt/ncDh0aKyByGlEFDlGPQtyKmzlRbEWvQNuBmwezgPN/6i6sGQvlSpjeaPJoE5eM0VpgkXLrLGOtviZZq+Xrt6WjBUdD7swiylew9UMuHLcNoap4yhKP+ecXv/qXUpeKd3/EbkNny5DwSn9iuoND+4YgRmDt7pOZQb4/okWJVAbqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUYa5NMDlfIce2d/rHyM1USfj9vMCXN8CPHiVFrzJBA=; b=sMoQ1pjHE+8+r1Q8PGEu3NiMYpILsrU28PFSRvsnDAzpCcSbnG3RONWBlS7fH2VAlS2ICWxlNFuJNAv9BAmBd0GMCFMcmyu5WTdUPnUWopAiB3kvIDiwgT89pLQC+yNpYN5XH64Kefl38pAzdDULWMWY8vpFMmw+hr5C+rM94IRh5fZJOe8RZ2pzbMLaWiWrLQCWcAo8qz00XkZjVxdO7BIhmZn/faLmOyhFNiYxDIMlh3IS//6wrgu0RdZgJyy9k+CQfNekKeev061bKWHU4eanWCG+6nTK0mHlzfq23PRI1degcS601aDtXgcFg8KPGMjs7HIj3mGukeoQhntqbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by DSVPR11MB9693.namprd11.prod.outlook.com (2603:10b6:8:34c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.6; Tue, 25 Aug 2026 16:19:00 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0360.005; Tue, 25 Aug 2026 16:19:00 +0000 Message-ID: <993f64a0-40b2-4ea6-8604-c1475bad7816@intel.com> Date: Wed, 26 Aug 2026 00:18:51 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/9] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains To: Reinette Chatre , Chen Yu CC: , , , , , , , , , References: <7eaafec96fb5494d3f4b927fa295d5b756f82c64.1784968626.git.yu.c.chen@intel.com> <9a86b245-916a-43ed-9bee-897aa3432a89@intel.com> <9229fbc4-812d-4747-8d2f-f5db3179037f@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <9229fbc4-812d-4747-8d2f-f5db3179037f@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TPYP295CA0029.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::6) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|DSVPR11MB9693:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aa20110-81ca-46d2-037d-08df02c49229 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|366016|1800799024|10067099003|22082099003|18002099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: oGQp+1qpfS0VAvIVq6I/IcWZjbfXHRv/Lmx4bIBJAO3hSGooPRsSgnknYigWnmmJ7i4BriKCsvFk1CFBw+NPWwxy7pXgOHyEn7KKvg8bLMFHQ+4EKAzAFxPokjwe5dWmuQc8MrGgnPTPv02pDCiqtGFFNCqPiOF1jga2O9oTJHWPQ3ljuZyaOE++svT4+EEJUDp+5CzsIQX3i0bBaYZ92Uuy0xdBUndu40s4VUl7ipVTwquJF3b06odMoRzf/h5avVTRoslsvZVbP5ALaJSu6HxHXDrDA9xhyH96TU3zientOXvr00rqA2wrFB5piFM2Y25oYdacMnZkkqMCi7j/rqbKod7dEY5aFU/Rzi3Dej7b752vTVMO5IGO7PM6yjV0VLXTASqpd3xVUruIsyl2tTb05vCke6KGe4WUO717mA54XfgSdCC2w65Sq89pixAt32yx50vmyScj3b+W1yllWQrArd4JBmaCNnpwfQtyeearpA4yU6HnAnjMVpJFuMeJm+RO4z1Uz5Ya1B98Sd3iCzqTLXB+/ayDYrfE/jpYOuGPSMRfV0w4oP1zEkXVpLVP3r1aWrx96UNd/COOqhvqcGY90KZSceySFyQSa2uQubavNiV4t7mJ4QiOmmpwVdoKcT8LhEuxWFB3bIA7uYc5m+sxkE2J/hwCJtYtlLNMM3E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(366016)(1800799024)(10067099003)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDFWMXdwT3dhTUtTY3N3WHF2ZGVVeEhidUlGTC9kLy9nM3lwM0YvQnpGVjJX?= =?utf-8?B?SEJSc1ZoaGx4eUI5d0ZWVks3dVRzNzRCTXk3b2NRZms4dnIyUDVyTnRiS2Vq?= =?utf-8?B?NTY5aDYvaVVvSGxVK3AwT0pyNXhVT2E1ZW1Jek5MaTdXSG4wN1NpTEVLeHBm?= =?utf-8?B?R0xHYnJSdzV4RXljZ2lHNzVmcEtRSkpQWktGSXZzdG1oaGZ4SlpBU3VOdVdu?= =?utf-8?B?WFlLelgwNnJxUURNT0NQRmYyaW5ZVVAvMUNOa1puWktWbkVPekZ1Sk9CMzhx?= =?utf-8?B?RTR4V3d4bHFaVU1kZlh0NnJhdjVURHVHeGJnMkJPT2tQUFdST0NPR0RPenFD?= =?utf-8?B?L2Q2c05OWkZNN0FlZFIxaTV1Qm1qZ1YxVnlWaFI0Zld3T1hzQ29tbG5WK3R4?= =?utf-8?B?OU8xU1Z2MWpXYmdoN0FCc1FIa2V4UjZVeSt0dWx6dHBDdUVIcEZ3NVdRQ2xQ?= =?utf-8?B?RW5UNDI0Ni9qdGFkTG5YQ1VDNWU3eWpnSU9idTBLRjY3alVUMmIyQ0piQzA5?= =?utf-8?B?bXhlY3pjOGVTaUxRUFV6b0FZa0FBNnB4djVuYjFMZjlodTk3dmJYM1NYZTJX?= =?utf-8?B?T0VJbFFLRjQxbnEvSFFzcmwzSzh5ZzhGejdzSDNrQVVXM01Ua3J2WHE1MTBE?= =?utf-8?B?dk4xUHZwT3k4R3BnNndZV2tLY2Mzb3lKWEZOL0Q2aHVQcGVqcXRKNDAxYlY0?= =?utf-8?B?cGk5cFdaYmtSNksyYUIxWHdZbENPc1FFY0RRZHdpbVBueFMyb3B1Q3Z6d0Ra?= =?utf-8?B?Z2x6TGhJY2M2aDFPVk15MEQwSHdCYktPM2sxaWJlV1RZS2haZnBlQnVOTXhI?= =?utf-8?B?UVNJam5GRUtWeDNDQzByMFZ1MVJiNTNIdDM1Tk9mZGFNSFRwZ3hsUDNwMWgv?= =?utf-8?B?Y1BKQUFKRE5YSjljQ1BhNHhMRkxmTzJNeU13ZGJHVWZpK053UEdBcVhWSGRw?= =?utf-8?B?QXVpcll5K3pWeDIwUGlSdDgrVmY5dm1jQjZXRWZDZE9yY3c3bFJiR2g3T283?= =?utf-8?B?SGxXMldIWmVvaFRkQzdaYmdYdXlwbzc0TmlVcU1MVk1LY1piZHVSanlOekdF?= =?utf-8?B?dCtxemY1Ym1kUVBFdGJESHJCbkhheFlGdTVBbmE0TVVPSTFTck5mTUYvSlIy?= =?utf-8?B?RTBuYWVKQStGTjRYL3FpQTJTRTZSZW1xeCtVVVlhdmZBb1I2NEl0MFJMYlZm?= =?utf-8?B?cmlSTnl3N3A2R2NjUy9MYTQ4MWtDcWVNdDRUUnlwVFJIQVNDeFowaVowdisr?= =?utf-8?B?dmhSL0pDTGlBR1dBS1VHNlRkSG1JMFpncWltTEdjbEtVZjdLLzZReVdtM3dk?= =?utf-8?B?OUJGRXZVYlFVSFh3ZlByVm85R2hXUGhXVXhxTXZlODZsRGRZd1hoMlNJKy80?= =?utf-8?B?TU9VaDJ3cFdRK2ZuUFV3OUFIdVlQQmNJUGxMOENsOXk0eER3TkU0UGxCcUVv?= =?utf-8?B?cFduNEpDeVRSSEpMYWV6dWxhWFNmYld2SjN6RzZNMHRtb1UrT1hzYVYwYXZa?= =?utf-8?B?Vk5zR0ZwdkJ4VU1STlpRT2p2NWgvdERwRU5jUHExemR0TnBRdlR0ZWVsSjNS?= =?utf-8?B?NUVUOFAwR2ZkdTBUSGpxVlFSUDB5dXF5MzlsM2kyRFgvTkpkNHpVU1p0Qnhv?= =?utf-8?B?ZUszNXR6cU8rRjJoVE9ucjhsN2s2R1Q5Nm9VK05DMVcwcHErLzREc0FqL0Vz?= =?utf-8?B?L09zNjQxRVNVTCtjWGVmanVSVTQ3ZmU4ajRzT2F5dTNJUkFwSVEza2dVWEFx?= =?utf-8?B?ci84VVRPa1Z5UXBnTkpSSlFTNlYxWEF5VkdaWXZsd3did3B2enlkaGFUL01Z?= =?utf-8?B?Z1BkUDhGSnl3RG5LeW8xZjNVSkFIa0c1RDdlbFY0ZlNtcTVQcVFSSk52ZFZI?= =?utf-8?B?OXIzWXhGYithcTJlZ1lFR21vTS9jM1FZRGRlWDJSZTZFT21sU3hpQkpZeCtB?= =?utf-8?B?b3Vra0dzVFpJSGNISmtSUzlXZHljZVdPODRsN1plUEpCVE5XWHZXT1YrWEpG?= =?utf-8?B?dmJ1cjlSUVpxdVhzaFMrWEdQZVpyUEZlczdoSDRqK1AxdWxBb1pNQ082Ly8w?= =?utf-8?B?TTk5TXJNUThVeEZ4WFJtb3NCMndOMm5ObXVpNVpEZEZ5UTFRQldvT01UOWdw?= =?utf-8?B?VGVya2d4MEdEcHFZMGJPWnpFUTJ6cGhUbEVta2dSOTZ4amRHUHZwQUJsY0Y5?= =?utf-8?B?SzVEanJhVjVOYTdSUnZuQjQxdVFRdFQ4ZUJCREh2WjZnL3BxUk1yNDlkL2dD?= =?utf-8?B?TlVxVmFRMWpWOU9UdWlzKzRvdWprcDh5MlM0SXNTTStwWXdxSnRwNjBOT1lT?= =?utf-8?B?MUpxZWJlQ0l0VDVEMDFMS1ZoVXRaL29FNURYUmxzT2R2TnNhelZBZz09?= X-Exchange-RoutingPolicyChecked: zKHQw3JhPlbV5C5VTDMmFLEUxofbPcZp8LT6DEN80EKRdn2s8Adg8oASkPtbGyVAncDPTpKFZvaoOgSQDpH1PYDimXb29s6B3vbAVAjWljlVxEQK+FEZ6EMqROX5UypKwZEB10nlet5aQ7GLsClxvAY/EIz6DjJ6CchV8OcMiel6sCKY4VRerCSG9QmqgkBoMmVew+xbDoTZtT/OYJC+5gao623VGPaxS5Wd+NkdoKGQZZVGDZv3UEpYw/fbBZ3KZVsOCPenOSF9MozlF51zgw+4RHsQDDNblrx/4U4fSDCn/OP34iCbv86qbtYZYbbkM+vEwJcjLrKS9eLxKr420A== X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa20110-81ca-46d2-037d-08df02c49229 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 16:19:00.0322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sh3NLGF/5VVp2uU4DzWNug/04tRGbRM8iZBT1YjKZzTpYGfyHAWG9NQqxAotkMLpDf07WPxYSbDTgrVrTJCm/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR11MB9693 X-OriginatorOrg: intel.com On 8/24/2026 11:54 PM, Reinette Chatre wrote: > Hi Chenyu, > [ ... ] > > Yes, code readability is a priority. It is not all just about code readability. Please consider > all the points I mentioned above. I do not see any justification for get_rdt_resources() > leaving dangling state on failure. This is something that will get tripped over in the next > inevitable refactor. Apart from that, adding a single "cleanup" function at one location down in > the call stack is convenient for *this* implementation based on the *current* state of the code but > while doing so it breaks custom, not just of resctrl but of the rest of the kernel also, and because > of that makes this code difficult to build on and maintain. > goto out; > > Above is the issue I mentioned earlier where get_rdt_resources() leaves dangling state. > If it cleaned up after itself on failure as is the custom in the kernel then > resctrl_arch_late_init() does not have to. > > If the goal is to avoid goto in __resctrl_arch_late_init() then the failure paths that > follow get_rdt_resources() can just call erdt_exit() directly to make obvious where what > needs to be cleaned up. > > As the suggestion is implemented the cleanup is inconsistent with __resctrl_arch_late_init() > doing its own cleanup for code run _after_ erdt_init() and leaving the erdt_init() cleanup > to be done further down the stack by __resctrl_arch_late_init()'s caller. While technically > correct this inconsistency adds unnecessary complexity and another place that will get tripped > over in the next inevitable refactor. > I see. This is very helpful guidance. I'll adjust the code accordingly. thanks, Chenyu