From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49680C433F5 for ; Mon, 21 Feb 2022 16:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380979AbiBUQoQ (ORCPT ); Mon, 21 Feb 2022 11:44:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380940AbiBUQoH (ORCPT ); Mon, 21 Feb 2022 11:44:07 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A67220E8; Mon, 21 Feb 2022 08:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1645461820; x=1676997820; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=HrHAf6gEsOAhEpFdK8CdrZ0sJZ9UBBtJ6ScL1EPZiy0=; b=1SRJSbbTYOY3q9ifajm7BjSJmBvWpraTrmsgqCaYHAZMjQqcmnnAvCha +1pijPaBC9I97Mx8TLLBow+LSJlXfl/X24zl2T1bJuGcq7R4SOUZFwIMo OcdOmx2qeVAGjrRbtvK8Tjo66+NSk5vywecaEO9AYFiQPMwUD44iuHqAI naOHJUGnrYILkKGA784W9gwHxfJASKkM9JBLOFkc5t6qpOsRJD4obnrYA IDq4DsTCvc8zttizvDSR9CpOaSbxlL88zi5LSNZfYtwcVeJmMEU2bO5QG 6wAuKGsq+RadtyEcYOS1qX2sSIWQBJqOv04c8PxNOkyV7SmUA6rlMw24P Q==; X-IronPort-AV: E=Sophos;i="5.88,386,1635231600"; d="scan'208";a="163022563" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 21 Feb 2022 09:43:39 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 21 Feb 2022 09:43:39 -0700 Received: from [10.12.68.158] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 21 Feb 2022 09:43:38 -0700 Message-ID: <994b754f-a8b0-2504-0803-d12fa9975ff5@microchip.com> Date: Mon, 21 Feb 2022 17:43:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] clk: lan966x: Fix linking error Content-Language: en-US To: Horatiu Vultur , , CC: , , , kernel test robot References: <20220219141536.460812-1-horatiu.vultur@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: <20220219141536.460812-1-horatiu.vultur@microchip.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/02/2022 at 15:15, Horatiu Vultur wrote: > If the config options HAS_IOMEM is not set then the driver fails to link > with the following error: > clk-lan966x.c:(.text+0x950): undefined reference to > `devm_platform_ioremap_resource' > > Therefor add missing dependencies: HAS_IOMEM and OF. > > Fixes: 54104ee02333 ("clk: lan966x: Add lan966x SoC clock driver") > Reported-by: kernel test robot > Signed-off-by: Horatiu Vultur Reviewed-by: Nicolas Ferre > --- > drivers/clk/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 4a8451f61f37..6f03c29c40be 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -232,6 +232,8 @@ config COMMON_CLK_GEMINI > > config COMMON_CLK_LAN966X > bool "Generic Clock Controller driver for LAN966X SoC" > + depends on HAS_IOMEM > + depends on OF > help > This driver provides support for Generic Clock Controller(GCK) on > LAN966X SoC. GCK generates and supplies clock to various peripherals -- Nicolas Ferre