From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Dharma Balasubiramani <dharma.b@microchip.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
Date: Sat, 31 Aug 2024 15:37:17 +0200 [thread overview]
Message-ID: <995f57b0-d164-4ad8-a409-80bdd876caa8@kernel.org> (raw)
In-Reply-To: <744af115-3cfe-4d3a-9bf7-e6ac0cd12378@microchip.com>
On 29/08/2024 16:42, Nicolas Ferre wrote:
> Alexandre,
>
> On 29/08/2024 at 16:10, Alexandre Belloni wrote:
>> On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote:
>>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
>>> since the SAMA7D65 PMC shares the same properties and clock requirements
>>> as the SAMA7G5.
>>
>> Shouldn't you rather use a fallback if you currently have no driver
>> change?
>
> The clock/pmc driver is (will be) different. Only the binding of the PMC
> uses the same properties and clocks specification as our recent SoCs (so
> can be added to the "enum").
I don't understand this patch. The binding without any users makes no
sense. For bindings without drivers, I understand you send it in
parallel from the DTS. But this one here will have a driver, right? In
such case IT MUST GO with the driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-31 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
2024-08-29 14:10 ` Alexandre Belloni
2024-08-29 14:42 ` Nicolas Ferre
2024-08-31 13:37 ` Krzysztof Kozlowski [this message]
2024-08-29 16:14 ` Conor Dooley
2024-08-31 13:32 ` claudiu beznea
2024-09-05 15:18 ` Nicolas Ferre
2024-09-05 15:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995f57b0-d164-4ad8-a409-80bdd876caa8@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox