From: Krzysztof Kozlowski <krzk@kernel.org>
To: Faraz Ata <faraz.ata@samsung.com>,
alim.akhtar@samsung.com, krzk+dt@kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, rosa.pila@samsung.com,
dev.tailor@samsung.com
Subject: Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports
Date: Fri, 4 Apr 2025 18:45:48 +0200 [thread overview]
Message-ID: <9970c307-eba6-4c2d-98de-1a0f846efcd4@kernel.org> (raw)
In-Reply-To: <20250404135006.1263827-1-faraz.ata@samsung.com>
On 04/04/2025 15:50, Faraz Ata wrote:
> Exynos Auto v920 SoC supports up to 18 UART ports.
> Hence changing the value of UART_NR to 18.
> ---
How v2, without changelog, is even worse than v1? It goes to wrong
direction.
Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-04 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250404134131epcas5p4794f2b1e5d289e1faa142c9093ea45e5@epcas5p4.samsung.com>
2025-04-04 13:50 ` [PATCH v2] tty: serial: samsung_tty: support 18 uart ports Faraz Ata
2025-04-04 16:45 ` Krzysztof Kozlowski [this message]
2025-04-11 6:23 ` Faraz Ata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9970c307-eba6-4c2d-98de-1a0f846efcd4@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=dev.tailor@samsung.com \
--cc=faraz.ata@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rosa.pila@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox