[patch] fix ucb initialization on collie

[patch] fix ucb initialization on collie

[Pavel Machek]

From: Dirk Opfer <Dirk@Opfer-Online.de>

Fix ucb initialization on collie. Wrong frequency was used and that
led to things not working quite correctly. (I had to actually disable
checks in my tree to get it to boot).

Signed-off-by: Pavel Machek <pavel@suse.cz>

PATCH FOLLOWS
KernelVersion: 2.6.18-rc1-git

diff --git a/arch/arm/mach-sa1100/collie.c b/arch/arm/mach-sa1100/collie.c
index a6bab50..5e2a84e 100644
--- a/arch/arm/mach-sa1100/collie.c
+++ b/arch/arm/mach-sa1100/collie.c
@@ -83,8 +83,8 @@ static struct scoop_pcmcia_config collie
 
 
 static struct mcp_plat_data collie_mcp_data = {
-	.mccr0          = MCCR0_ADM,
-	.sclk_rate      = 11981000,
+	.mccr0          = MCCR0_ADM | MCCR0_ExtClk,
+	.sclk_rate      = 9216000,
 };
 
 #ifdef CONFIG_SHARP_LOCOMO
diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c
index 632bc21..8a93563 100644
--- a/drivers/mfd/ucb1x00-core.c
+++ b/drivers/mfd/ucb1x00-core.c
@@ -479,7 +481,7 @@ static int ucb1x00_probe(struct mcp *mcp
 	mcp_enable(mcp);
 	id = mcp_reg_read(mcp, UCB_ID);
 
-	if (id != UCB_ID_1200 && id != UCB_ID_1300) {
+	if (id != UCB_ID_1200 && id != UCB_ID_1300 && id != UCB_ID_TC35143) {
 		printk(KERN_WARNING "UCB1x00 ID not found: %04x\n", id);
 		goto err_disable;
 	}

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [patch] fix ucb initialization on collie

[Richard Purdie]

On Fri, 2006-07-07 at 13:41 +0200, Pavel Machek wrote:
> From: Dirk Opfer <Dirk@Opfer-Online.de>
> 
> Fix ucb initialization on collie. Wrong frequency was used and that
> led to things not working quite correctly. (I had to actually disable
> checks in my tree to get it to boot).
> 

> @@ -479,7 +481,7 @@ static int ucb1x00_probe(struct mcp *mcp
>  	mcp_enable(mcp);
>  	id = mcp_reg_read(mcp, UCB_ID);
>  
> -	if (id != UCB_ID_1200 && id != UCB_ID_1300) {
> +	if (id != UCB_ID_1200 && id != UCB_ID_1300 && id != UCB_ID_TC35143) {
>  		printk(KERN_WARNING "UCB1x00 ID not found: %04x\n", id);

UCB_ID_TC35143 isn't defined in mainline, otherwise I'd ack this.

Richard

UCB1400 driver problem in pxa270

[saravanan_sprt]

Hi all,

I am a newbie in using UCB1400 chip. Iam using Toradex Colibri module PXA270 as my target system with UCB1400 chip integrated.
I have a problem in enabling the audio system using UCB1400. Can anyone point me, how could I enable and use the UCB1400 driver on linux 2.6.12 platform. I have applied Nicolas Pitre patches and configured kernel CONFIG_INPUT, CONFIG_SND, CONFIG_SOUND,CONFIG_SND_PXA2xx_AC97, CONFIG_SND_PXA2xx_PCM to  =y. The kernel builds well, but on boot the UCB1400 driver didn't gets registered and there are no more interrupts enabled in /proc/interrupts with following boot message,
.....
.....
ts: UCB1x00 touchscreen protocol output
Advanced Linux Sound Architecture Driver Version 1.0.9rc2 ( The MAr 24 10:34:34 2005 UTC)
ALSA device list:
  No soundcards found.
....
....

The problem seems to be due to driver_register(pxa2xx-ac97) and bus match.

Any help will be appreciated .

Thanks
Sara


--
This message was sent on behalf of saravanan_sprt@hotmail.com at openSubscriber.com
http://www.opensubscriber.com/message/linux-kernel@vger.kernel.org/2120108.html

UCB1400 driver problem in pxa270

[saravanan_sprt]

Hi all,

I am a newbie in using UCB1400 chip. Iam using Toradex Colibri module PXA270 as my target system with UCB1400 chip integrated.
I have a problem in enabling the audio system using UCB1400. Can anyone point me, how could I enable and use the UCB1400 driver on linux 2.6.12 platform. I have applied Nicolas Pitre patches and configured kernel CONFIG_INPUT, CONFIG_SND, CONFIG_SOUND,CONFIG_SND_PXA2xx_AC97, CONFIG_SND_PXA2xx_PCM to  =y. The kernel builds well, but on boot the UCB1400 driver didn't gets registered and there are no more interrupts enabled in /proc/interrupts with following boot message,
.....
.....
ts: UCB1x00 touchscreen protocol output
Advanced Linux Sound Architecture Driver Version 1.0.9rc2 ( The MAr 24 10:34:34 2005 UTC)
ALSA device list:
  No soundcards found.
....
....

The problem seems to be due to driver_register(pxa2xx-ac97) and bus match.

Any help will be appreciated .

Thanks
Sara


--
This message was sent on behalf of saravanan_sprt@hotmail.com at openSubscriber.com
http://www.opensubscriber.com/message/linux-kernel@vger.kernel.org/4398951.html

Re: UCB1400 driver problem in pxa270

[Nicolas Pitre]

On Fri, 27 Oct 2006, saravanan_sprt@hotmail.com wrote:

> Hi all,
> 
> I am a newbie in using UCB1400 chip. Iam using Toradex Colibri module PXA270 as my target system with UCB1400 chip integrated.
> I have a problem in enabling the audio system using UCB1400. Can anyone point me, how could I enable and use the UCB1400 driver on linux 2.6.12 platform. I have applied Nicolas Pitre patches and configured kernel CONFIG_INPUT, CONFIG_SND, CONFIG_SOUND,CONFIG_SND_PXA2xx_AC97, CONFIG_SND_PXA2xx_PCM to  =y. The kernel builds well, but on boot the UCB1400 driver didn't gets registered and there are no more interrupts enabled in /proc/interrupts with following boot message,
> .....
> .....
> ts: UCB1x00 touchscreen protocol output
> Advanced Linux Sound Architecture Driver Version 1.0.9rc2 ( The MAr 24 10:34:34 2005 UTC)
> ALSA device list:
>   No soundcards found.
> ....
> ....
> 
> The problem seems to be due to driver_register(pxa2xx-ac97) and bus match.
> 
> Any help will be appreciated .

Look in arch/arm/mach-pxa/mainstone.c for mst_audio_device.  This is an 
example of the  platform_device structure the pxa2xx-ac97 driver is 
looking for.


Nicolas