public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luke Jones <luke@ljones.dev>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com,
	pobrn@protonmail.com, linux@roeck-us.net,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v11] asus-wmi: Add support for custom fan curves
Date: Wed, 29 Sep 2021 00:43:57 +1300	[thread overview]
Message-ID: <99750R.GZYR2PKX93HX@ljones.dev> (raw)
In-Reply-To: <1d9d4de26d0c862acf3e579f14de9596027f3c3b.camel@hadess.net>

Sure, the path is similar to 
/sys/devices/platform/asus-nb-wmi/hwmon/hwmon4/pwm1_enable where hwmon4 
will likely be different depending on init, and pwm2_enable is the 
second fan if it exists. The values are 1,2,3 - where 1 = fan curve 
enabled/manual, 2 = auto. 3 here is custom extra that writes default 
curve back then defaults to 2.

As I understand it, this should be adhering to the accepted kernel 
standard, so if you use this for ASUS laptops, then it should carry 
over to other brands that implement it also.

Hope this is helpful,
Luke.

On Tue, Sep 28 2021 at 13:36:57 +0200, Bastien Nocera 
<hadess@hadess.net> wrote:
> On Wed, 2021-09-08 at 11:22 +1200, Luke D. Jones wrote:
>>  Add support for custom fan curves found on some ASUS ROG laptops.
>> 
>>  These laptops have the ability to set a custom curve for the CPU
>>  and GPU fans via two ACPI methods.
>> 
>>  This patch adds two pwm<N> attributes to the hwmon sysfs,
>>  pwm1 for CPU fan, pwm2 for GPU fan. Both are under the hwmon of the
>>  name `asus_custom_fan_curve`. There is no safety check of the set
>>  fan curves - this must be done in userspace.
>> 
>>  The fans have settings [1,2,3] under pwm<N>_enable:
>>  1. Enable and write settings out
>>  2. Disable and use factory fan mode
>>  3. Same as 2, additionally restoring default factory curve.
>> 
>>  Use of 2 means that the curve the user has set is still stored and
>>  won't be erased, but the laptop will be using its default auto-fan
>>  mode. Re-enabling the manual mode then activates the curves again.
>> 
>>  Notes:
>>  - pwm<N>_enable = 0 is an invalid setting.
>>  - pwm is actually a percentage and is scaled on writing to device.
> 
> I was trying to update:
> https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/merge_requests/80
> but I don't understand what files I need to check for what values to
> detect whether custom fan curves were used.
> 
> Can you help me out here?
> 
> Also, was this patch accepted in the pdx86 tree?
> 
> Cheers
> 



  reply	other threads:[~2021-09-28 11:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 23:22 [PATCH v11 0/1] asus-wmi: Add support for custom fan curves Luke D. Jones
2021-09-07 23:22 ` [PATCH v11] " Luke D. Jones
2021-09-08 12:32   ` kernel test robot
2021-09-08 17:49   ` kernel test robot
2021-09-28 11:36   ` Bastien Nocera
2021-09-28 11:43     ` Luke Jones [this message]
2021-09-28 11:56       ` Hans de Goede
2021-09-28 11:59         ` Luke Jones
2021-09-28 12:03           ` Hans de Goede
2021-09-28 12:15             ` Luke Jones
2021-09-28 14:11               ` Hans de Goede
2021-09-28 11:44     ` Hans de Goede
2021-09-28 11:56       ` Luke Jones
2021-09-28 11:59         ` Hans de Goede
2021-09-28 12:01           ` Luke Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99750R.GZYR2PKX93HX@ljones.dev \
    --to=luke@ljones.dev \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pobrn@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox