From: Dave Hansen <dave.hansen@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Brendan Jackman <jackmanb@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: update comment about pgd_list
Date: Mon, 11 May 2026 13:43:31 -0700 [thread overview]
Message-ID: <997a80dd-8905-40e6-b449-01d9c78c4cef@intel.com> (raw)
In-Reply-To: <1aa93abe-5145-439a-bd8e-a0d4375da889@zytor.com>
On 5/11/26 12:49, H. Peter Anvin wrote:
> The PAE code comment should still remain.
>
> I don't know if the 32-bit PAE code is still suffering from Xen-induced drain
> bramage (using a whole page to store 32 bytes),
Actually, I think I recently spread the brain damage even further. The
kmalloc()'d PGDs are completely gone now. PGDs all directly out of the
page allocator. It actually simplified the 32-bit code quite a bit.
> but it is nevertheless true in a fashion -- as there are a maximum
> of 3 kernel PDE pages, they are considered the de facto top level of
> the kernel page tables.
Here's what I ended up with:
> +/*
> + * List of all process' PGD pages (excluding init_mm and some other special
> + * system-wide PGDs). Mainly used to keep the kernel portion of the address
> + * space in sync across mms.
> + */
I think what you're saying is that those (max) 3 kernel PDE pages are
static and all PGDs always have the same value in there. So, there's no
synchronizing necessary on PAE. That was definitely true for a long time.
But we actually also moved away from that:
> https://lore.kernel.org/all/20250414173232.32444FF6@davehans-spike.ostc.intel.com/
PTI forced some PMD unsharing. So I just moved 32-bit over to not share
kernel PMDs at all. It made the 32-bit code quite a bit simpler,
although it wastes memory when PTI is disabled.
next prev parent reply other threads:[~2026-05-11 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260323-pgd_list-comment-v2-1-77ccf2dc77e8@google.com>
2026-05-11 11:35 ` [PATCH v2] x86: update comment about pgd_list Brendan Jackman
2026-05-11 19:49 ` H. Peter Anvin
2026-05-11 20:43 ` Dave Hansen [this message]
2026-05-11 18:27 ` [tip: x86/mm] x86: Update " tip-bot2 for Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=997a80dd-8905-40e6-b449-01d9c78c4cef@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox