From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbeABPed (ORCPT + 1 other); Tue, 2 Jan 2018 10:34:33 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39031 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbeABPea (ORCPT ); Tue, 2 Jan 2018 10:34:30 -0500 X-Google-Smtp-Source: ACJfBou7ECXtRwpyM4V7B2KsX0Di+eZ0GcQLvYUbMzBlfnTuNj+zOcJqaxkrj3fvb41C/O0y29uuUA== Subject: Re: [PATCH] platform/x86: silead_dmi: Add entry for the Teclast X98 Plus II To: Paul Cercueil , Darren Hart , Andy Shevchenko Cc: linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180102134239.3579-1-paul@crapouillou.net> From: Hans de Goede Message-ID: <997c8889-4e7f-89e3-b8a5-0cccd3cf5000@redhat.com> Date: Tue, 2 Jan 2018 16:34:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180102134239.3579-1-paul@crapouillou.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, On 02-01-18 14:42, Paul Cercueil wrote: > Add touchscreen platform data for the Teclast X98 Plus II tablet. > > Signed-off-by: Paul Cercueil Looks good to me: Acked-by: Hans de Goede You should probably send a v2 rebased on top of: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy Which has several additional entries compared to the version you used as base. Regards, Hans > --- > drivers/platform/x86/silead_dmi.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 266535c2a72f..ebe8692a2868 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -171,6 +171,22 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = { > .properties = digma_citi_e200_props, > }; > > +static const struct property_entry teclast_x98plus2_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-size-x", 2048), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1280), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_STRING("firmware-name", > + "gsl1686-teclast_x98plus2.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + { } > +}; > + > +static const struct silead_ts_dmi_data teclast_x98plus2_data = { > + .acpi_name = "MSSL1680:00", > + .properties = teclast_x98plus2_props, > +}; > + > static const struct dmi_system_id silead_ts_dmi_table[] = { > { > /* CUBE iwork8 Air */ > @@ -271,6 +287,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > }, > }, > + { > + /* Teclast X98 Plus II */ > + .driver_data = (void *)&teclast_x98plus2_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TECLAST"), > + DMI_MATCH(DMI_PRODUCT_NAME, "X98 Plus II"), > + }, > + }, > { }, > }; > >