From: "Kohli, Gaurav" <gkohli@codeaurora.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: Query: Crash is coming during /prod/PID/stat and do_exit of same task
Date: Tue, 16 Jan 2018 15:14:59 +0530 [thread overview]
Message-ID: <9982db93-e392-f6da-e70b-d38d818cd4ff@codeaurora.org> (raw)
In-Reply-To: <20180116072008.GA6918@avx2>
On 1/16/2018 12:50 PM, Alexey Dobriyan wrote:
> On Tue, Jan 16, 2018 at 11:06:47AM +0530, Kohli, Gaurav wrote:
>> On 1/10/2018 10:50 AM, Alexey Dobriyan wrote:
>>
>>>> We are seeing crash in do_task_stat while accessing stack pointer, It
>>>> seems same task has already completed do_exit call.
>>>> So it seems a race between them:
>>> Please, post exact kernel version and struct task_struct::usage if you
>>> still have that kernel core (or even full task_struct)
>> Hi Alexey,
>>
>> We are working on 4.9.65 and Please find below usage value and other task_struct value,
>> please let me know if some other data required as well.
> Kernel stacks live their own lives nowadays, the code needs try_get_task_stack().
>
Hi Alexey,
Yes , agree we have to put some check like below
if (permitted && (task->flags & PF_DUMPCORE) && try_get_task_stack(task)) {
eip = KSTK_EIP(task);
esp = KSTK_ESP(task);
}
Or instead of this also , can't we check whether task is in exiting path or not by checking some flags like PF_EXITING.
Regards
Gaurav
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-16 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 5:20 Query: Crash is coming during /prod/PID/stat and do_exit of same task Alexey Dobriyan
2018-01-16 5:36 ` Kohli, Gaurav
2018-01-16 7:20 ` Alexey Dobriyan
2018-01-16 9:44 ` Kohli, Gaurav [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-09 13:33 Kohli, Gaurav
2018-01-15 10:04 ` Kohli, Gaurav
2018-01-15 11:02 ` John Ogness
2018-01-15 12:30 ` Kohli, Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9982db93-e392-f6da-e70b-d38d818cd4ff@codeaurora.org \
--to=gkohli@codeaurora.org \
--cc=adobriyan@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox