From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
Kumar Gala <galak@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>, Scott Wood <oss@buserror.net>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: powerpc/83xx: fix use-after-free on mpc831x_usb_cfg()
Date: Mon, 8 Jul 2019 17:21:48 +0200 [thread overview]
Message-ID: <99840e11-e0e6-b3f4-e35b-56ef4ec39417@web.de> (raw)
In-Reply-To: <1562317084-13140-1-git-send-email-wen.yang99@zte.com.cn>
> The np variable is still being used after the of_node_put() call,
> which may result in use-after-free.
> We fix this issue by calling of_node_put() after the last usage.
I imagine that this commit description can be improved a bit more
(by mentioning the influence of “immr_node”?).
How do you think about to omit the word “We” here?
> This patatch also do some cleanup.
Should the renaming of a jump label be contributed in a separate update
step of a small patch series besides a wording without a typo?
Regards,
Markus
prev parent reply other threads:[~2019-07-08 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 8:58 [PATCH] powerpc/83xx: fix use-after-free on mpc831x_usb_cfg() Wen Yang
2019-07-08 15:21 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99840e11-e0e6-b3f4-e35b-56ef4ec39417@web.de \
--to=markus.elfring@web.de \
--cc=benh@kernel.crashing.org \
--cc=cheng.shengyu@zte.com.cn \
--cc=galak@kernel.crashing.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox