From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbcCXPW1 (ORCPT ); Thu, 24 Mar 2016 11:22:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:48821 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbcCXPWM convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2016 11:22:12 -0400 From: Johannes Thumshirn To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Date: Thu, 24 Mar 2016 16:22:10 +0100 Message-ID: <9996648.qnGD5sR833@c203> User-Agent: KMail/5.1.2 (Linux/4.5.0-1-default; KDE/5.20.0; x86_64; ; ) In-Reply-To: References: <20160324012520.21436.22505.stgit@dwillia2-desk3.jf.intel.com> <7155730.1PoRE68eiN@c203> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Donnerstag, 24. März 2016 08:21:20 CET Dan Williams wrote: > On Thu, Mar 24, 2016 at 5:22 AM, Johannes Thumshirn wrote: > > On Mittwoch, 23. März 2016 18:26:03 CET Dan Williams wrote: > >> Consolidate the information for issuing i/o to a blk-namespace, and > >> eliminate some pointer chasing. > >> > >> Signed-off-by: Dan Williams > >> --- > > > > [...] > > > >> BUG_ON(len > PAGE_SIZE); > >> > >> - err = nd_blk_do_bvec(blk_dev, bip, bvec.bv_page, len, > >> - bvec.bv_offset, rw, > >> iter.bi_sector); > >> + err = nsblk_do_bvec(nsblk, bip, bvec.bv_page, len, > >> + bvec.bv_offset, rw, iter.bi_sector); > >> > >> if (err) { > >> > >> - dev_info(&blk_dev->nsblk->common.dev, > >> + dev_dbg(&nsblk->common.dev, > >> > >> "io error in %s sector %lld, len > >> %d,\n", > >> (rw == READ) ? "READ" : "WRITE", > >> (unsigned long long) > >> iter.bi_sector, len); > > > > Why is an I/O error suddently a debug message instead of an error? > > True, that's a jarring change not described in the log, should > probably be its own patch. The rationale is that upper layers already > have error prints for failed commands and this one is redundant. OK, thanks for the clarification -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850