From: Dave Jiang <dave.jiang@intel.com>
To: Robin Murphy <robin.murphy@arm.com>,
Hanjun Guo <guohanjun@huawei.com>, <lpieralisi@kernel.org>,
<sudeep.holla@arm.com>
Cc: kernel test robot <lkp@intel.com>,
Jianmin Lv <lvjianmin@loongson.cn>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
<rafael@kernel.org>, <lenb@kernel.org>,
<linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI
Date: Thu, 1 Jun 2023 08:24:43 -0700 [thread overview]
Message-ID: <9997bc22-239b-ccc5-e7d4-a179144fdde3@intel.com> (raw)
In-Reply-To: <1751a3c4-a6b0-0a8c-cd1b-c05d25d30380@arm.com>
On 6/1/23 03:31, Robin Murphy wrote:
> On 2023-06-01 02:48, Hanjun Guo wrote:
>> Hi Dave,
>>
>> Sorry for the late reply, I have some comments inline.
>>
>> On 2023/5/23 0:06, Dave Jiang wrote:
>>> arm64 build can be done without CONFIG_ACPI. The ifdef bits for
>>> acpi_arch_dma_setup() is placed inside CONFIG_ACPI. When CONFIG_ACPI is
>>> not set, this causes warning reported by kernel test bot. Move the
>>> prototype declaration for acpi_arch_dma_setup() outside of CONFIG_ACPI.
>>
>> ...
>>
>>>
>>>>> drivers/acpi/arm64/dma.c:7:6: warning: no previous prototype for
>>>>> function 'acpi_arch_dma_setup' [-Wmissing-prototypes]
>>> void acpi_arch_dma_setup(struct device *dev)
>>> ^
>>> drivers/acpi/arm64/dma.c:7:1: note: declare 'static' if the
>>> function is not intended to be used outside of this translation unit
>>> void acpi_arch_dma_setup(struct device *dev)
>>> ^
>>> static
>>> 1 warning generated.
>>
>> drivers/acpi can only be compiled with CONFIG_ACPI=y, so
>> drivers/acpi/arm64/ will be the same, not sure how to trigger
>> this compile warning.
>>
>> I disable CONFIG_ACPI on my ARM64 machine, but didn't get the
>> warning you reported.
>
> Looking at the linked LKP report, it seems it's it's explicitly trying
> to build drivers/acpi/arm64/ despite the config:
>
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> O=build_dir ARCH=arm64 olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/acpi/arm64/
>
> So I guess it's a problem with the LKP setup? In general, trying to
> build arbitrary parts of the kernel which are configured out can never
> be expected to work.
It seems to be a problem triggered because I was working on some patches
that added obj-y at the drivers/Makefile for acpi/ and opened the ACPI
dir for !CONFIG_ACPI compile. The code has been reworked after comments
from Rafael. So this is no longer a problem. Please ignore patch. Sorry
about the noise.
>
> Thanks,
> Robin.
prev parent reply other threads:[~2023-06-01 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 16:06 [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI Dave Jiang
2023-06-01 1:48 ` Hanjun Guo
2023-06-01 10:31 ` Robin Murphy
2023-06-01 15:24 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9997bc22-239b-ccc5-e7d4-a179144fdde3@intel.com \
--to=dave.jiang@intel.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox