From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238BD4B048A for ; Sun, 16 Aug 2026 00:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786838471; cv=none; b=bhomSWFYskkHsPQLtQFLfOSMh58JtSEqgV6171sClYFJJCWMVI0Agk30hurFWqHs0dtXRP6SvfU6NVDvi1OAe8+SOI5VP+5ICpIv8PNjPWTNOaBdQB5MLhorpnM0n9mK73VMP80Puf0bR3CJhQu6cYfyZ9QNTuetBmQzreBHnoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786838471; c=relaxed/simple; bh=jTIAf27M5NzIQ/HT/8Rvh+AaCXsZu3pvrlyi40ZBRCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EjeHmcjHGGmP91ujkG8k2pze2mYkM1lPHxJLPXTIuarnkdggFcUxX25POH74uc9by7n96o/KzHp4HJLMFvDhlVlRykknn34+few3Sx0max4xSJ3ZymURhhr7M7TLRz/TqbI69gCYRj0wml4E7PiS9JedaEDtRY+v+kpvb1X18zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c2sZsASq; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c2sZsASq" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47fe89fb333so1292609f8f.3 for ; Sat, 15 Aug 2026 17:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786838468; x=1787443268; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S05GcFVUlDeLHwWGA/nTU8ZIeoXZY8FYWxsLnhiIPVM=; b=c2sZsASqOafDhVRjgNP5TcTOWfDZufwws1Ch2OfcHGf78tGd7CYl4BlqlKIOwiQjxw BS2JwTuPcwu3lMNrAQ6Ffy0sPoAN7scJ7hmEMWg0pcxJ2E/T4k1Q4iWiuzuBebic/UZq tld+2u5BgnffpullZOJHpaOCqOybvbPKyfIZV3MLxaptM95ApWPIAy3OEXpSs9EvZTNC KZFWoJoT2BQL64oo9G87g5OnWa7IxFB9dmhMyiB1KWUzpi2TQ5ga878/Yr/B2pTX3g2I szCVoA5psQBCJ8hi1MOlwZfW2VaRNx4HJxk2HTx7zkJWbCEq4/BwMyG0Xre7Yr/9fZU4 rH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786838468; x=1787443268; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=S05GcFVUlDeLHwWGA/nTU8ZIeoXZY8FYWxsLnhiIPVM=; b=iv6adP2Dl6rrdd8aFJu0q4ASeuuEyTniZ3Yk4w21WfdJMs1VaiBiYy+GsLDK52+dPa W0APhvV4ywVQsYKFwPJGxFaW+IpGAxqIdoZrCen6VVKoFIHcAGB6wwYmlPMrNhobZRTt BwaLAYov46MJw1zrdSwpMKnBXPZT6lDrAm7pm1Uv7+FadMjPmUexHPfWi6pTXsvD/XC4 q0QdAQ/p8hvo+0VcflDmowjc6WsqhrOxVkpfzXCVnOvIlKviJtQdWNoxREQCnaxvUWts AqVEgg202Mn9lDnW96+FZlilTJ1DA7q1Tq1tUi9Zz23xIza1l7uYFkzbgqJnjw6zf5Ha 6BjA== X-Forwarded-Encrypted: i=1; AHgh+RpjixuZMviPrmuZjGyg9fwiXF/C741jF28q7P4EZTa+Sn+0ONSO+ma4pOThTOL4m2v5QVSGdgJzVtAx5JQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzKZFvZ3rkuWk0QWqwzB1mQO/rbatXb3jHr1GGp2j/pgxVPpyln sZwflTLzwA9iPKcQzj4Sv8jyzcFYZVjednTGcYKTsXiJtP54K9mwG2bQ2Odk5SHT X-Gm-Gg: AR+sD12PRWG9eGFimb/jObZNG73Ci7Ns35eF4JjIkTcF7DAklWHi/jFr2lDPijoVH5m MqEyNM5vl9cYJQvOrHLdFcZClvKnmeI7plnu2JbUagHRSDby6jjEfvo6oV4VR3MezEN7DW+556G pYHhHeLCqUzAugUa1tE2G3TvQR1WQE9QdlnbH6I8Hb1oO/yI9UEdmjFkleTVJKxMw5tu57fnneg 2OTsaGk+bGZBj7drK532Gjon8KNPE3fnrcl7iss4sP9MZ4f3X95mED5jUA6IjN6DPWLtQwnFp9Q DwNwY/dkv+f+Ff7hJmY7GaBaFDMaRtYtojwZz17m47IbS78yVVULTuDJpJ4Gh781+v+vMFZe+d5 qiA6PO8dbAcZRztJ9fLrRhxVGNNQEaQmvbmO2gKSteNSUmXBvS+VxjukyI3hC/jCkMKw4NSjkZX Rc5Cl1t6NS9m629B2dPLU3o6L+2fBceb97PEhewU4rV5RPwXN28c1PsTX6xIZW00dkdBiYXLg2D +S+7QqfYFvqSc6UD3BzZTOuqaoYVJGBa6c05gj49FoaMbuDRbf85d6Y X-Received: by 2002:a5d:44cc:0:b0:47f:f908:ba7b with SMTP id ffacd0b85a97d-481607a8812mr19313208f8f.23.1786838468080; Sat, 15 Aug 2026 17:01:08 -0700 (PDT) Received: from [10.128.10.232] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c1307sm21029207f8f.27.2026.08.15.17.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Aug 2026 17:01:07 -0700 (PDT) Sender: Julian Braha Message-ID: <999edd39-43d0-4973-96ce-a205283277ff@gmail.com> Date: Sun, 16 Aug 2026 01:01:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS To: Rosen Penev Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, arnd@arndb.de, chancel.liu@nxp.com, jonsmirl@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260802144855.3596995-1-julianbraha@gmail.com> Content-Language: en-US From: Julian Braha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Rosen, On 8/2/26 22:14, Rosen Penev wrote: > On Sun, Aug 2, 2026 at 7:49 AM Julian Braha wrote: >> >> SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select >> SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is >> met. This causes unmet dependencies such as: >> >> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 >> Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] >> Selected by [m]: >> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] >> >> SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its >> dependency on SND_SOC_AC97_BUS is met. >> >> Let's resolve all 3 unmet dependencies by adding the dependencies on >> PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar >> options in this subsystem do. >> >> These unmet dependency bugs were detected by kconfirm, a static analysis tool >> for Kconfig. >> >> Fixes: a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.") >> Fixes: 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika") >> Signed-off-by: Julian Braha >> --- >> sound/soc/fsl/Kconfig | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig >> index 8ae59c094878..a5d7cf534391 100644 >> --- a/sound/soc/fsl/Kconfig >> +++ b/sound/soc/fsl/Kconfig >> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 >> >> config SND_MPC52xx_SOC_PCM030 >> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" >> - depends on PPC_MPC5200_SIMPLE >> + depends on PPC_BESTCOMM >> select SND_SOC_MPC5200_AC97 >> select SND_SOC_WM9712 >> help >> @@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030 >> config SND_MPC52xx_SOC_EFIKA >> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" >> depends on PPC_EFIKA >> + depends on PPC_BESTCOMM > does this really depend on PPC_BESTCOMM? Yes, BestComm is the co-processor found on Freescale MPC5200. - Julian Braha