From: "Bayduraev, Alexey V" <alexey.v.bayduraev@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>,
Alexei Budankov <abudankov@huawei.com>,
Riccardo Mancini <rickyman7@gmail.com>
Subject: Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation
Date: Wed, 30 Jun 2021 10:22:25 +0300 [thread overview]
Message-ID: <99af01bf-93e1-31ca-c1bf-bb28c6fcb35b@linux.intel.com> (raw)
In-Reply-To: <CAM9d7ci4M5hNTXm4iqj91=DXnC=qUpeWMXAHsFtgBq=J=VTqKw@mail.gmail.com>
Hi,
On 30.06.2021 9:09, Namhyung Kim wrote:
> On Mon, Jun 28, 2021 at 1:11 AM Bayduraev, Alexey V
> <alexey.v.bayduraev@linux.intel.com> wrote:
>>
>> Hello,
>>
>> On 27.06.2021 3:46, Namhyung Kim wrote:
>>> Hello,
>>>
>>> On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev
>>> <alexey.v.bayduraev@linux.intel.com> wrote:
>>>>
>>>> Changes in v7:
>>>> - fixed possible crash after out_free_threads label
>>>> - added missing pthread_attr_destroy() call
>>>> - added check of correctness of user masks
>>>> - fixed zsts_data finalization
>>>>
>> [SNIP]
>>> Thanks for your work, mostly looks good now.
>>>
>>> I have a question, where are the synthesized records saved?
>>> Is it the data.0 file?
>>
>> Thanks for the review.
>>
>> As I understand the synthesized records (as well as other user-space
>> records) are saved to perf.data/data, kernel records are saved to
>> perf.data/data.<CPU>
>
> Ah, ok. I saw you added a reader for the file in patch 20/20.
> Maybe we can save all tracking records (task/mmap) there
> in the future.
>
> For the patchset,
> Acked-by: Namhyung Kim <namhyung@gmail.com>
Thank you so much for your time spent on this review.
Can I resend the patchset with additional patch that address your nitpicks?
To not re-review the entire patchset.
Regards,
Alexey
>
> Thanks,
> Namhyung
>
prev parent reply other threads:[~2021-06-30 7:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 8:42 [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 01/20] perf record: Introduce thread affinity and mmap masks Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 02/20] perf record: Introduce thread specific data array Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 03/20] perf record: Introduce thread local variable Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 04/20] perf record: Stop threads in the end of trace streaming Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 05/20] perf record: Start threads in the beginning " Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 06/20] perf record: Introduce data file at mmap buffer object Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 07/20] perf record: Introduce data transferred and compressed stats Alexey Bayduraev
2021-06-30 8:05 ` Riccardo Mancini
2021-06-30 12:19 ` Bayduraev, Alexey V
2021-06-30 14:48 ` Bayduraev, Alexey V
2021-06-22 8:42 ` [PATCH v7 08/20] perf record: Init data file at mmap buffer object Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 09/20] tools lib: Introduce bitmap_intersects() operation Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 10/20] perf record: Introduce --threads=<spec> command line option Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 11/20] perf record: Document parallel data streaming mode Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 12/20] perf report: Output data file name in raw trace dump Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 13/20] perf session: Move reader structure to the top Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 14/20] perf session: Introduce reader_state in reader object Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 15/20] perf session: Introduce reader objects in session object Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 16/20] perf session: Introduce decompressor into trace reader object Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 17/20] perf session: Move init into reader__init function Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 18/20] perf session: Move map/unmap into reader__mmap function Alexey Bayduraev
2021-06-22 8:42 ` [PATCH v7 19/20] perf session: Load single file for analysis Alexey Bayduraev
2021-06-27 0:49 ` Namhyung Kim
2021-06-22 8:42 ` [PATCH v7 20/20] perf session: Load data directory files " Alexey Bayduraev
2021-06-30 6:14 ` Namhyung Kim
2021-06-27 0:46 ` [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Namhyung Kim
2021-06-28 8:11 ` Bayduraev, Alexey V
2021-06-30 6:09 ` Namhyung Kim
2021-06-30 7:22 ` Bayduraev, Alexey V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99af01bf-93e1-31ca-c1bf-bb28c6fcb35b@linux.intel.com \
--to=alexey.v.bayduraev@linux.intel.com \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox