From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <Linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
"Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH 1/4] perf vendor events: Add core event list for Icelake Server
Date: Wed, 2 Jun 2021 21:55:49 +0800 [thread overview]
Message-ID: <99bc4c45-d67f-d53f-7ca7-1e770ef585a6@linux.intel.com> (raw)
In-Reply-To: <YLdq/H8CXYgHWzCL@kernel.org>
Hi Arnaldo,
On 6/2/2021 7:26 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 25, 2021 at 09:42:55AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, May 24, 2021 at 09:08:12AM +0800, Jin, Yao escreveu:
>>> Could you pull the top 4 patches from "https://github.com/yaoj/icx-events.git"?
>
>>> perf vendor events: Update event list for Icelake Client
>>> perf vendor events: Add metrics for Icelake Server
>>> perf vendor events: Add uncore event list for Icelake Server
>
>>> The patch is too big and it's possibly corrupted by mailing system.
>
>> Thanks, applied.
>
> So, this is failing 'perf test 10', see details below, please run 'perf
> test' before pushing patches upstream.
>
> Triple checking:
>
> ⬢[acme@toolbox perf]$ git cherry-pick 8f74f0f4dbf6361f0a5d21c5da260fbbf7597286
> Removing tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> [perf/core 6971d24f4d04ccfa] Revert "perf vendor events intel: Add metrics for Icelake Server"
> Date: Wed Jun 2 08:16:20 2021 -0300
> 1 file changed, 327 deletions(-)
> delete mode 100644 tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> ⬢[acme@toolbox perf]$ git log --oneline -1
> 6971d24f4d04ccfa (HEAD -> perf/core) Revert "perf vendor events intel: Add metrics for Icelake Server"
> ⬢[acme@toolbox perf]$ (rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -k CORESIGHT=1 BUILD_BPF_SKEL=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin) > /dev/null 2>&1 ; perf test 10
> 10: PMU events :
> 10.1: PMU event table sanity : Ok
> 10.2: PMU event map aliases : Ok
> 10.3: Parsing of PMU event table metrics : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
> ⬢[acme@toolbox perf]$ git reset --hard HEAD~
> HEAD is now at 0ab8009b3e8dd6ba Merge remote-tracking branch 'torvalds/master' into perf/core
> ⬢[acme@toolbox perf]$ (rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -k CORESIGHT=1 BUILD_BPF_SKEL=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin) > /dev/null 2>&1 ; perf test 10
> 10: PMU events :
> 10.1: PMU event table sanity : Ok
> 10.2: PMU event map aliases : Ok
> 10.3: Parsing of PMU event table metrics : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED!
> ⬢[acme@toolbox perf]$
>
> - Arnaldo
>
> ⬢[acme@toolbox perf]$ git bisect bad
> d89bf9cab1f613e4496f929d89477b2baaad1ea9 is the first bad commit
> commit d89bf9cab1f613e4496f929d89477b2baaad1ea9
> Author: Jin Yao <yao.jin@linux.intel.com>
> Date: Sat May 8 13:06:20 2021 +0800
>
> perf vendor events intel: Add metrics for Icelake Server
>
> Add JSON metrics for Icelake Server to perf.
>
> Based on TMA metrics 4.21 at 01.org.:
>
> https://download.01.org/perfmon/
>
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Acked-by: Ian Rogers <irogers@google.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Link: http://lore.kernel.org/lkml/c0f27643-bebb-2912-56ed-f7abec7dbde3@linux.intel.com
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> .../pmu-events/arch/x86/icelakex/icx-metrics.json | 327 +++++++++++++++++++++
> 1 file changed, 327 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> ⬢[acme@toolbox perf]$
>
>
> ⬢[acme@toolbox perf]$ perf test -v 10 |& tail -40
> parsing 'inst_retired.any / cpu_clk_unhalted.distributed'
> parsing '( 1 * ( fp_arith_inst_retired.scalar_single + fp_arith_inst_retired.scalar_double ) + 2 * fp_arith_inst_retired.128b_packed_double + 4 * ( fp_arith_inst_retired.128b_packed_single + fp_arith_inst_retired.256b_packed_double ) + 8 * ( fp_arith_inst_retired.256b_packed_single + fp_arith_inst_retired.512b_packed_double ) + 16 * fp_arith_inst_retired.512b_packed_single ) / cpu_clk_unhalted.distributed'
> parsing 'uops_executed.thread / ( uops_executed.core_cycles_ge_1 / 2 )'
> parsing 'cpu_clk_unhalted.distributed'
> parsing 'inst_retired.any / mem_inst_retired.all_loads'
> parsing 'inst_retired.any / mem_inst_retired.all_stores'
> parsing 'inst_retired.any / br_inst_retired.all_branches'
> parsing 'inst_retired.any / br_inst_retired.near_call'
> parsing 'br_inst_retired.all_branches / br_inst_retired.near_taken'
> parsing 'inst_retired.any / ( 1 * ( fp_arith_inst_retired.scalar_single + fp_arith_inst_retired.scalar_double ) + 2 * fp_arith_inst_retired.128b_packed_double + 4 * ( fp_arith_inst_retired.128b_packed_single + fp_arith_inst_retired.256b_packed_double ) + 8 * ( fp_arith_inst_retired.256b_packed_single + fp_arith_inst_retired.512b_packed_double ) + 16 * fp_arith_inst_retired.512b_packed_single )'
> parsing 'inst_retired.any'
> parsing 'lsd.uops / (idq.dsb_uops + lsd.uops + idq.mite_uops + idq.ms_uops)'
> parsing 'idq.dsb_uops / (idq.dsb_uops + lsd.uops + idq.mite_uops + idq.ms_uops)'
> parsing 'l1d_pend_miss.pending / ( mem_load_retired.l1_miss + mem_load_retired.fb_hit )'
> parsing 'l1d_pend_miss.pending / l1d_pend_miss.pending_cycles'
> parsing '( itlb_misses.walk_pending + dtlb_load_misses.walk_pending + dtlb_store_misses.walk_pending ) / ( 2 * cpu_clk_unhalted.distributed )'
> parsing '64 * l1d.replacement / 1000000000 / duration_time'
> parsing '64 * l2_lines_in.all / 1000000000 / duration_time'
> parsing '64 * longest_lat_cache.miss / 1000000000 / duration_time'
> parsing '64 * offcore_requests.all_requests / 1000000000 / duration_time'
> parsing '1000 * mem_load_retired.l1_miss / inst_retired.any'
> parsing '1000 * mem_load_retired.l2_miss / inst_retired.any'
> parsing '1000 * ( ( offcore_requests.all_data_rd - offcore_requests.demand_data_rd ) + l2_rqsts.all_demand_miss + l2_rqsts.swpf_miss ) / inst_retired.any'
> parsing '1000 * mem_load_retired.l3_miss / inst_retired.any'
> parsing '1000 * l2_lines_out.silent / inst_retired.any'
> parsing '1000 * l2_lines_out.non_silent / inst_retired.any'
> parsing 'cpu_clk_unhalted.ref_tsc / msr@tsc@'
> parsing '(cpu_clk_unhalted.thread / cpu_clk_unhalted.ref_tsc) * msr@tsc@ / 1000000000 / duration_time'
> parsing '( ( 1 * ( fp_arith_inst_retired.scalar_single + fp_arith_inst_retired.scalar_double ) + 2 * fp_arith_inst_retired.128b_packed_double + 4 * ( fp_arith_inst_retired.128b_packed_single + fp_arith_inst_retired.256b_packed_double ) + 8 * ( fp_arith_inst_retired.256b_packed_single + fp_arith_inst_retired.512b_packed_double ) + 16 * fp_arith_inst_retired.512b_packed_single ) / 1000000000 ) / duration_time'
> parsing 'cpu_clk_unhalted.thread / cpu_clk_unhalted.ref_tsc'
> parsing '1 - cpu_clk_unhalted.one_thread_active / cpu_clk_unhalted.ref_distributed'
> parsing 'cpu_clk_unhalted.thread:k / cpu_clk_unhalted.thread'
> parsing '( 64 * ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) / 1000000000 ) / duration_time'
> parsing '1000000000 * ( cha@event\=0x36\,umask\=0x21\,config\=0x40433@ / cha@event\=0x35\,umask\=0x21\,config\=0x40433@ ) / ( cha_0@event\=0x0@ / duration_time )'
> parsing 'cha@event\=0x36\,umask\=0x21\,config\=0x40433@ / cha@event\=0x36\,umask\=0x21\,config\=0x40433\,thresh\=1@'
> parsing '( 1000000000 * ( cha@event\=0x36\,umask\=0x21\,config\=0x40433@_pmm / cha@event\=0x35\,umask\=0x21\,config\=0x40433@_pmm ) / cha_0@event\=0x0@ )'
> check_parse_fake failed
> test child finished with -1
> ---- end ----
> PMU events subtest 4: FAILED!
> ⬢[acme@toolbox perf]$
>
Very sorry about the "Parsing of PMU event table metrics with fake PMUs" failure! I will resubmit
the patch also with other c-state metrics update.
Thanks
Jin Yao
next prev parent reply other threads:[~2021-06-02 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 1:24 [PATCH 0/4] perf vendor events: Add events for Icelake Server and update for Icelake Client Jin Yao
2021-05-10 1:24 ` [PATCH 1/4] perf vendor events: Add core event list for Icelake Server Jin Yao
2021-05-20 16:08 ` Ian Rogers
2021-05-21 19:41 ` Arnaldo Carvalho de Melo
2021-05-24 1:08 ` Jin, Yao
2021-05-25 12:42 ` Arnaldo Carvalho de Melo
2021-06-02 11:26 ` Arnaldo Carvalho de Melo
2021-06-02 13:55 ` Jin, Yao [this message]
2021-06-02 15:12 ` Arnaldo Carvalho de Melo
2021-06-03 0:56 ` Jin, Yao
2021-05-10 1:24 ` [PATCH 2/4] perf vendor events: Add uncore " Jin Yao
2021-05-20 16:13 ` Ian Rogers
2021-05-21 1:38 ` Jin, Yao
2021-05-10 1:24 ` [PATCH 3/4] perf vendor events: Add metrics " Jin Yao
2021-05-20 16:40 ` Ian Rogers
2021-05-21 2:01 ` Jin, Yao
2021-05-10 1:24 ` [PATCH 4/4] perf vendor events: Update event list for Icelake Client Jin Yao
2021-05-20 16:44 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99bc4c45-d67f-d53f-7ca7-1e770ef585a6@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox