From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934119AbcIEUSE (ORCPT ); Mon, 5 Sep 2016 16:18:04 -0400 Received: from mout.web.de ([212.227.15.3]:57885 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbcIEURM (ORCPT ); Mon, 5 Sep 2016 16:17:12 -0400 Subject: [PATCH 2/7] ACPI-APEI-HEST: Use kmalloc_array() in hest_ghes_dev_register() To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" References: <566ABCD9.1060404@users.sourceforge.net> <9834b713-2c7b-ad6d-76a5-b1db40f561fc@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, trivial@kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <99c1e4fd-5fa8-bc22-59b1-e6784806a314@users.sourceforge.net> Date: Mon, 5 Sep 2016 22:17:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <9834b713-2c7b-ad6d-76a5-b1db40f561fc@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nOVd0XeA0+EtN/J7MNVhpEjl6IVtaPZXZHbX+YUtylQ7kj2qoAI ApJkGFySNl6oho2jTfxzdNnCloLSIcAjJ3trhgfNL5m6DD7pLr6OdyyWErp+QytD7/P+zDJ Bo5hhcdn5nIMW82lAKYnfufbimjynpvDFkNuhRqgrfl8rHoBCL5bcomn+wvSXDdzd9McjEs aq96ANicBzyY3r/HIPN6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:P5Gzoo5q+RI=:Y98Gkahpy9/YoAP7T063hM Bw5c5uZShMGVw76wFNeCG1xk5MVlCx0SZg4s5MO4HE6eOlF0pHF1TTPMjW/00sIjI6KCTzmup g7cIXm1iKsT626Zz1M8I5InhCugCm524lKhkk9BwOAu1sfUx3ET3ri1emi3q6+HH/8+7ySR97 aPjmlQNZQC5IWFNzFLkzqut0EKqHxUfxXzNpLs/Q4wwCHPh0E/E72Bm6TXlLtnFseNtBIPk52 Pi6HctDKClUnsbPNFSdB5/8v+8Fvsdqo8e/6qva9S0UlDtZsh6wXNPaAZ81pwR0z40Xya8+cV xJsUpnw1ggTeOFSf4PfD8ARIBw/NzY3MgCV5ru0qVJOsKGIyv6xXUlTx8VFg2hIS5gB6EOVSa 2XCcWMcGuCp0KvQsbWnV9XEUAYra6EmPwcenn4LTRAQ2QsqWBc7A+s2mwW8fg69OySyzrJ1M0 aeRpe5GETzaSgoJwp5VdKBeyzaCZHBHw1B60TvqmbULnb6GUUtKmQ+WsAR2LzFWtg8rLEYb5u Umtd9w901MUuoYMmV3LATcW0J0BLuDLjRGPCPcfZVJs7wYgRd9JRaq/dFiuS7khDggERk0w27 JuLN6PNUjYK75LpNTM1ZfrDhoFQ2qc9qCwekOf8W9Yus38m13gF5TyAOueajzRRGKvFJFyrHS HG9QjJKzGunyNGvaB/Ed2zgxjv3lUfTzEsAwTGxgqSWUk7MAXeGPxWgYGr8I6tih7tcpn+uuY LJsqOAfnJyYx55oixfMQ3uXa7YFmKnxfZEAxP0+Ly1yPVGC488N9KwSI0ktFd8ABHB1mephzt q6mQLYm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 5 Sep 2016 20:55:33 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/acpi/apei/hest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c index e170885..a852237 100644 --- a/drivers/acpi/apei/hest.c +++ b/drivers/acpi/apei/hest.c @@ -186,7 +186,9 @@ static int __init hest_ghes_dev_register(unsigned int ghes_count) struct ghes_arr ghes_arr; ghes_arr.count = 0; - ghes_arr.ghes_devs = kmalloc(sizeof(void *) * ghes_count, GFP_KERNEL); + ghes_arr.ghes_devs = kmalloc_array(ghes_count, + sizeof(*ghes_arr.ghes_devs), + GFP_KERNEL); if (!ghes_arr.ghes_devs) return -ENOMEM; -- 2.10.0