RE: [PATCH net-next v9 08/13] net:ethernet:realtek:rtase: Implement net_device_ops

Justin Lai
2023-10-16T01:50:41Z

>
> > > > +static void rtase_tx_timeout(struct net_device *dev, unsigned int
> > > > +txqueue) {
> > > > + rtase_sw_reset(dev);
> > >
> > > Do you actually see this happening? The timeout is set pretty high,
> > > i think 5 seconds. If it does happen, it probably means you have a
> > > hardware/firmware bug. So you want to be noisy here, so you get to
> > > know about these problems, rather than silently work around them.
> >
> > I would like to ask if we can dump some information that will help us
> > understand the cause of the problem before doing the reset? And should
> > we use netdev_warn to print this information?
>
> You might want to look at 'devlink health'.
>
> Andrew

Thank you for your suggestion.