From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v2 2/2] ASoC: cs35l56: Allow factory calibration through ALSA controls
Date: Thu, 26 Mar 2026 10:16:47 +0000 [thread overview]
Message-ID: <99f88e55-ea07-4b19-a0b8-73fb22c2c3ca@opensource.cirrus.com> (raw)
In-Reply-To: <6e2d8ded-00ce-4148-bd93-aded513b9f30@sirena.org.uk>
On 25/03/2026 5:53 pm, Mark Brown wrote:
> On Wed, Mar 25, 2026 at 05:08:41PM +0000, Richard Fitzgerald wrote:
>> Add support for using ALSA controls to trigger a factory calibration.
>> This is protected by a new Kconfig option so that it is only available
>> if explicitly enabled in the kernel. By default it is not enabled.
>
>> Factory calibration is normally done through debugfs files.
>> Google have requested that factory calibration can be performed by
>> repair shops. These repair shops only have access to the standard
>> "user" kernel, which does not include debugfs.
>
> AFAICT this doesn't have an EFI write command like the debugfs code does
> (when you write "store_uefi"). I don't mind, just wanted to double
> check that this is desirable?
>
That's correct. The Google devices don't have EFI storage, they will
use the CAL_DATA_RB control to extract the calibration data to save it
in their own persistent storage.
next prev parent reply other threads:[~2026-03-26 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 17:08 [PATCH v2 0/2] ASoC: cs35l56: Support for factory calibration through ALSA controls Richard Fitzgerald
2026-03-25 17:08 ` [PATCH v2 1/2] ASoC: soc.h: Add SOC_SINGLE_BOOL_EXT_ACC() to allow setting access flags Richard Fitzgerald
2026-03-25 17:08 ` [PATCH v2 2/2] ASoC: cs35l56: Allow factory calibration through ALSA controls Richard Fitzgerald
2026-03-25 17:53 ` Mark Brown
2026-03-26 10:16 ` Richard Fitzgerald [this message]
2026-03-26 10:20 ` [PATCH v2 0/2] ASoC: cs35l56: Support for " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99f88e55-ea07-4b19-a0b8-73fb22c2c3ca@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox