From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628203FA5F2 for ; Tue, 26 May 2026 12:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779799495; cv=none; b=IvY5kTHOwx9LGR9InIej7RXmnvEyQ/DOEXl13Ek2hTAWaKjh7pwcoHV/buz8QeV1OeHjS7HAclxZefHg8sJRNc/M/31LNnno+UmI8KG9RBZh3XmaHykaxU1JyQJ5MdToGqCQxoQPB6m/T24fd09j+09CARuLY/65FHKKE0JWKbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779799495; c=relaxed/simple; bh=QJVt0DZUFPNyn17DknLw2RSrN9lmnBVjMM8ckov1/TQ=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:References: Cc:In-Reply-To:To; b=Gd7wFu7qkVaPNJtJDmqerieE2+1m4DQH3tbbZu3NoLHH11GZjAQz80EqKG/zbcQHPZdu12RLx7wfnXS+O88NrfYxvYMdH5TBb1U3ZR/OVKTwOOzdXQJsGA0xsWwik+jK6F5UrApFlqHzdFWeyDRssxikRwxVCojeisnyU1XRVIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lMS4QbMv; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lMS4QbMv" Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779799480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aZ+//Mss6s3qN1JOKyb8a9R/2rcpN6zHPDWF1XVoNaU=; b=lMS4QbMv0ataQoK+t4dIGZlupkZyH7x6RZe3qqCqB4MaCzKmuAJRFdKp34LnWMyV5A2rnt Xof+1+4FqRBp1nKu5FFUgPY5sPYwUwkswp6lw6QrA8IRFyn8VvKWO73b2q05qk/HqUZsF6 yNGeOe07/UT0urDqO25kBowxlNWmROQ= Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/cma: fix reserved page leak on activation failure Date: Tue, 26 May 2026 20:44:01 +0800 Message-Id: <9A340644-CD8D-44B0-BBC5-43D29E9D046E@linux.dev> References: Cc: Muchun Song , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Frank van der Linden , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: To: Oscar Salvador , Usama Arif X-Migadu-Flow: FLOW_OUT > On May 26, 2026, at 19:51, Oscar Salvador (SUSE) wr= ote: >=20 > =EF=BB=BFOn Tue, May 26, 2026 at 04:30:03AM -0700, Usama Arif wrote: >> On Fri, 22 May 2026 14:26:58 +0800 Muchun Song = wrote: > ... >>> diff --git a/mm/cma.c b/mm/cma.c >>> index c7ca567f4c5c..a30075507d41 100644 >>> --- a/mm/cma.c >>> +++ b/mm/cma.c >>> @@ -188,10 +188,13 @@ static void __init cma_activate_area(struct cma *c= ma) >>>=20 >>> /* Expose all pages to the buddy, they are useless for CMA. */ >>> if (!test_bit(CMA_RESERVE_PAGES_ON_ERROR, &cma->flags)) { >>> - for (r =3D 0; r < allocrange; r++) { >>> + for (r =3D 0; r < cma->nranges; r++) { >>> + unsigned long start_pfn; >>> + >>> cmr =3D &cma->ranges[r]; >>> + start_pfn =3D r < allocrange ? early_pfn[r] : cmr->early_pf= n; >>=20 >> Should this be r <=3D allocrange? Yes. So I sent a v2 to fix it last Saturday. https://lore.kernel.org/linux-mm/20260523060123.2207992-1-songmuchun@bytedan= ce.com/ Thanks. >=20 > Yes, I think you are right. I missed that. >=20 > early_pfn[alloc_range] holds the last assignment, so we should start > from the next one reading cmr->early_pfn. >=20 >=20 >=20 > -- > Oscar Salvador > SUSE Labs