From: stuart hayes <stuart.w.hayes@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data buffer
Date: Thu, 29 May 2025 17:12:29 -0500 [thread overview]
Message-ID: <9a1a1d6e-4d0b-4c0a-aa5c-31ee9ad65da2@gmail.com> (raw)
In-Reply-To: <b975c429-25e9-3cff-8d43-d2b40f8fb9bd@linux.intel.com>
On 5/25/2025 5:14 PM, Ilpo Järvinen wrote:
> On Thu, 22 May 2025, Stuart Hayes wrote:
>
>> The dell_rbu driver will use memset to clear the data held by each packet
>
> Please add () after function names.
>
>> when it is no longer needed (when the driver is unloaded, the packet size
>> is changed, etc).
>>
>> The amount of memory that is cleared is (currently) the normal packet
>> size. However, the last packet in the list may be smaller. Fix this to
>
> One space is enough after .
>
>> only clear the memory actually used by each packet, to prevent it from
>> writing past the end of data buffer.
>>
>> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
>
> Fixes tag?
>
>> ---
Thank you for reviewing this! I sent a new version (V3) with these fixes
(and a module version bump).
prev parent reply other threads:[~2025-05-29 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 20:09 [PATCH v2 0/3] platform/x86: dell_rbu: Packet data fixes Stuart Hayes
2025-05-22 20:09 ` [PATCH v2 1/3] platform/x86: dell_rbu: Fix sparse warning Stuart Hayes
2025-05-22 20:09 ` [PATCH v2 2/3] platform/x86: dell_rbu: Fix list usage Stuart Hayes
2025-05-22 20:09 ` [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data buffer Stuart Hayes
2025-05-25 22:14 ` Ilpo Järvinen
2025-05-29 22:12 ` stuart hayes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a1a1d6e-4d0b-4c0a-aa5c-31ee9ad65da2@gmail.com \
--to=stuart.w.hayes@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).