public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <Victor.Duicu@microchip.com>
To: <krzk@kernel.org>
Cc: <corbet@lwn.net>, <linux@roeck-us.net>,
	<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh@kernel.org>, <linux-kernel@vger.kernel.org>,
	<krzk+dt@kernel.org>, <linux-doc@vger.kernel.org>,
	<conor+dt@kernel.org>, <Marius.Cristea@microchip.com>
Subject: Re: [PATCH v10 1/2] dt-bindings: hwmon: add support for MCP998X
Date: Fri, 20 Feb 2026 14:58:40 +0000	[thread overview]
Message-ID: <9a39d9f1d97eea245dd194a2db481297b92c6fbf.camel@microchip.com> (raw)
In-Reply-To: <20260217-sincere-spotted-lionfish-d7abca@quoll>

Hi Krzysztof,

> 
> 
> ...
> 
> 
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - microchip,mcp9933
> > +      - microchip,mcp9933d
> > +      - microchip,mcp9982
> > +      - microchip,mcp9982d
> > +      - microchip,mcp9983
> > +      - microchip,mcp9983d
> > +      - microchip,mcp9984
> > +      - microchip,mcp9984d
> > +      - microchip,mcp9985
> > +      - microchip,mcp9985d
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> 
> Your interrupt-names say 1 item is correct, so these are de-synced.
> They
> should be always constrained the same way.
> 

We want to allow the user to use none, one or both interrupts.
It was my mistake to set maxItems instead of minItems to interrupts.
Do you find the following approach agreeable?

  interrupts:
    minItems: 1

  interrupt-names:
    minItems: 1
    items:
      - enum: [alert-therm, therm-addr, sys-shtdwn]
      - enum: [therm-addr, sys-shtdwn]

...

Thank you for your reply,
Victor

  reply	other threads:[~2026-02-20 14:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 14:06 [PATCH v10 0/2] add support in hwmon for MCP998X Victor Duicu
2026-02-17 14:06 ` [PATCH v10 1/2] dt-bindings: hwmon: add support " Victor Duicu
2026-02-17 20:11   ` Krzysztof Kozlowski
2026-02-20 14:58     ` Victor.Duicu [this message]
2026-02-21 14:34       ` Krzysztof Kozlowski
2026-02-23 11:09         ` Victor.Duicu
2026-02-23 11:23           ` Krzysztof Kozlowski
2026-03-04  8:15             ` Victor.Duicu
2026-02-17 14:06 ` [PATCH v10 2/2] " Victor Duicu
2026-03-08 16:56   ` Guenter Roeck
2026-03-30 12:01     ` Victor.Duicu
2026-03-30 16:00       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a39d9f1d97eea245dd194a2db481297b92c6fbf.camel@microchip.com \
    --to=victor.duicu@microchip.com \
    --cc=Marius.Cristea@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox