From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932926AbdBVQlR (ORCPT ); Wed, 22 Feb 2017 11:41:17 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33975 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932851AbdBVQlI (ORCPT ); Wed, 22 Feb 2017 11:41:08 -0500 Subject: Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code To: Namhyung Kim References: <1487758103-7953-1-git-send-email-treeze.taeung@gmail.com> <1487758103-7953-5-git-send-email-treeze.taeung@gmail.com> Cc: Arnaldo Carvalho de Melo , "linux-kernel@vger.kernel.org" , Jiri Olsa , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Jiri Olsa From: Taeung Song Message-ID: <9a50532c-e845-31f2-237a-dfee6bbbfb2f@gmail.com> Date: Thu, 23 Feb 2017 01:41:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2017 08:27 PM, Namhyung Kim wrote: > On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote: >> The output of perf-annotate has a problem. >> It is so confusing that the output is mixed with >> both source code and assembly code. >> IMHO, we need readable annotate view based on source code, >> not mixed view. (not depending on 'objdump -S') >> >> And to do that, we can collect actual source code per function(sym) >> using addr2line() and we can handle 'struct source_code' >> that contains each line of code. >> >> In near future, it would be used for new annotate view based on >> actual source code per function(sym). > > I think this is just a preparation so you'd be better sending it with > your new annotate view patchset later. > > Thanks, > Namhyung I got it! I thought it is needed to separate a big commit into several commits so I sent this patch before including new annotate view. But as you said, it seems like just a preparation without important point(new view). So I'll send v2 with new annotate view ! Thanks, Taeung