From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E761223B61B for ; Tue, 25 Aug 2026 03:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787628524; cv=none; b=K/ETkc3dHw0TKRazn/E3y094dWoMVSwe727SoCsSgWpS90UHNUEJlXhvBIN86fR1QkPu7Zszf0DS54Fo3zK9g5+KguD93wegOhuopq4QSYgaCVrILCK2o7Tv9hax9A2bvMsRr1+OVqR9ykir/0fOh84nTErODi6hrPo7b9QUbT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787628524; c=relaxed/simple; bh=vuiFROzEsC+g1XxUvKEPeCnooqPCI3YWqjwXN6cL/rk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dMVm8D/GbzG1ue9xLXQiq0oaLvdVjh1vGFEBC+LIpL7PVD3F+8TVW/d141zXp0T5wxHGj3MM08h4TMA4tOM1vtmizNQ9Ys+Uqedm+WUeKt4rLZPDV2cE7PIfXixFJGC1XCTEySkJ0qa4k55eqqPElxwxjgl1Y2ANg6XIvLbYjos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Sk5kKTFi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jEV69Tg1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Sk5kKTFi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jEV69Tg1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P2RGhp120828 for ; Tue, 25 Aug 2026 03:28:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CSiqRQOs0eoPECWmncRej6CsGnfaG7zegCnVzga5O8E=; b=Sk5kKTFi6hd3qAmc DHnTG6U9WmqxBBtyV8nygQdbUh9dmXKmE3p7qQo707486h6xXCqI31K7tgYDrttj 2UgdTUylxFuK2O5r6msJldbRb3u987EhfCDf4c/isquHmINPJpA0ZoXxXUFnWHE7 hAqEG0TqvVa7KBjoS0Y9vrOtFGf13xPPA9HRE/SzZVtD8yG40bevk4CDGe4g/WQl zwuW4JGIMiGW1GKJXtyaOb7tS8NiISjhGWxSOV4Ry2jphQBZ8bHKdus8KVExtXdZ C2AxuX4sM0ARaxhaWWOhHcrO+EYsqVtKYwKeeUZiSSDDDJhx6ZhRPDYq283z08Wv sDKRkQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8t3dsvux-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 03:28:41 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2d6f710f066so228425ad.1 for ; Mon, 24 Aug 2026 20:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787628521; x=1788233321; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CSiqRQOs0eoPECWmncRej6CsGnfaG7zegCnVzga5O8E=; b=jEV69Tg1f2ww6BOqo3ZdLmqUt+bQrvISGy3swfY+uQdF8P5c+zD6UNw5lycSwlKGhM H0RBLlsZZ6F90oB/+IVtZzFjtb9baref0uVtWvWWuuPuIbDgI1utKontc4YBW2+x54db W6ppQLgbmUmFA1uid6oirii5nY5RlYZYM0639KEJ4+I60A0Fy9bRELqJEWdYj/XKQLTM JhoFbLJOPitwcq0VZUgE1skfJn36rSLnQGWJo5QfXNrT26NWzLo/h1PneNnSLsRPq4Bv OVnr14NhT5JethueCUM3Q8fzf2fcYWUwn/owTcsJ8npNHIEboNx1xZAmZxBmdZ6ShYiq +Sdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787628521; x=1788233321; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CSiqRQOs0eoPECWmncRej6CsGnfaG7zegCnVzga5O8E=; b=JQGwDyMKh4PGvsmuHDkKW0o3rSJcbRY0FDziT7X3MOPpOxsGXOEYL/j5iMq14ruaZC cOU4CdVhxkbaPLV5GbP1gxy4ToKJSRSnChPi/c7jLDwQVmrWIegu8uWkqEkfXVMqCDgr +z749N7KcAbS/57GJ9MuBIllK2bZSYiXLPCNoiI6M41z27Mg+1mNFVDvdORu0TuQV/hG M04AJlrK3OCK4GYfxWh6GnMRS2giTxab1E0tP3nwTzI9CC64vuBHDRO0no9S6r6fiM86 CXKKS9C75pz9dog+FsQqMdNL7o8tqhPXtUV1P4fAPnD6BI3QIvgXsHvUpLIajoo63SfW 2oVA== X-Forwarded-Encrypted: i=1; AHgh+Rr/KIvf489tXZ/1dK3SUNByQP2CyJexONOH4l7Lv7s6Mwob//R5ccwoX1vv9b7GLzbel0gbk9psoaqANP8=@vger.kernel.org X-Gm-Message-State: AFuF++lpU5KavGCFk0apzS9ypZMjWrWI4e/Gcd9jlLukAjNqOM6y1Ysl 4AXgEspexuikjxo3D/q6lrue7tpakeLaK58OPwlR/jWEc6TuLttpmrcB3sIg4dV0eOe8RroqkhT 7OxvFu4HBDv0WaaWxQof03Xde+qfwOFjyAkUWEaofCnKVg3hU0u5uDC2zubvf3MC4/1g= X-Gm-Gg: AR+sD10/oqIPTZQQQkFk585Rnzq9HCmWMg3Ogs97/cpSP3Xe0j4GnupAYBT75s3VROW qvv3O45kNL7QiyNBSw7w+EOqpBUBXA1E4LJCRthMAoBFRKsLyi9GX8rLx0ggnMDLRGnb8/5s5PW YI9zB3h3YJB9jJGqErsd3vQ1Ecvno5dp9XjCaoCMHiG31plXT9TT+9xnUanWZuwMdgAs8yvt3ZT 1AMoOnYY5T5Az8tveQ+tG0IhUrXRpdznEBmfZnOM5xXnXSas8ewDcqvnhYsWRPqijWUgvOjAFjj HbvUai8zRLSLioEk+JCMy4M9C5OOgQ4hWkyx40VFNcVkVCheveQHQE1wQ2CUxS0UHHtciqSRY+V feyiZ/W5Wa9QKfpaeJz8U2WOk9EB+Uw== X-Received: by 2002:a17:902:fd88:b0:2d3:7122:833 with SMTP id d9443c01a7336-2d6dcb1a6d0mr47860545ad.15.1787628520672; Mon, 24 Aug 2026 20:28:40 -0700 (PDT) X-Received: by 2002:a17:902:fd88:b0:2d3:7122:833 with SMTP id d9443c01a7336-2d6dcb1a6d0mr47860095ad.15.1787628520256; Mon, 24 Aug 2026 20:28:40 -0700 (PDT) Received: from [192.168.1.132] ([70.95.199.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f90c0a59sm38057474eec.9.2026.08.24.20.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 20:28:39 -0700 (PDT) Message-ID: <9a556733-79db-4f69-a149-b678c23cab7d@oss.qualcomm.com> Date: Mon, 24 Aug 2026 20:28:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 8/9] arm64: dts: qcom: kodiak: Describe EUD UTMI path using child node To: Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Peter Chen , Rob Herring , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260811213610.2956147-1-elson.serrao@oss.qualcomm.com> <20260811213610.2956147-9-elson.serrao@oss.qualcomm.com> <906db71e-8f2d-4ab8-856d-915ff9dfef77@oss.qualcomm.com> Content-Language: en-US From: Elson Serrao In-Reply-To: <906db71e-8f2d-4ab8-856d-915ff9dfef77@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: J_A6K5RBwTh1KoI2hr3xEY1U0Z8x3W8M X-Authority-Analysis: v=2.4 cv=OLAXGyaB c=1 sm=1 tr=0 ts=6a8d0be9 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=uHxescsG3rBdxcXwcPaeSg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=oarc27XjrnPoJnDktLYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: J_A6K5RBwTh1KoI2hr3xEY1U0Z8x3W8M X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDAyNiBTYWx0ZWRfX51X6lIw8PZRm 5r9uaOPD3IDZo0kt+4jQRLg8kbOF0HWcBY4b6AjS6/OR1t4wHtrLnSpGRv5EGB7ksX59GgfKkY5 gf+c6FavI17e3dGA947ys50b/4Cq5yM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDAyNiBTYWx0ZWRfX6sDEPWmsTvR+ zlBD8s9ir6insROVve2luJ1ErDrNO69Nloq/bvmO3BKHyE0iq7jCygnWhuVqf7/TskarBowOCJ2 ga3FO2OruFLbVeDYAObak5CfqCrBpM6WF5raOhURZY/rSZZCZrhQWizb0Ic79Vwd9TagyjZk+qX d16zPMdy+XBe+I4fqBNGmieRCAdQlXExh00g+gXZrPrS8+No8pfuYPMdcM4qbJ26DkMocnjBSU1 TPSqwlGApY/5szyuIYbwfQJy0U1rEQHqFWQRHzfcGEvyzlbde4OUrMJ4Z5GYlBZD+I9ZTOmd5O4 4OU4cSOE8ax4AQ9sNc8nYIJRcrGyaVqIkQ5Uw21cxXdUgcM5YKVHzovaFxWSO6h42oFEDVpblaA lfcgeOINQ8bBlTTCsP2IjSnI6nxt09Jha3cqcDecg4JydfbjdE28yElOJgHivnGrrmZgtiBOWvL eilUNBHoD5/HwyXL1Xw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250026 On 8/24/2026 6:48 AM, Konrad Dybcio wrote: > On 8/11/26 11:36 PM, Elson Serrao wrote: >> The existing EUD description uses a legacy single-path representation >> that assumes uniform UTMI routing. This was sufficient for minimal >> configurations where the USB port operated only in device mode and role >> switching was not considered. > > [...] > >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + eud_usb: endpoint { >> + remote-endpoint = <&usb_1_dwc3_hs>; > > This change alone will trip "connection is not bi-directional" warnings, > as board DTs override that endpoint already > Patch 8 on its own would indeed trigger the "connection is not bi-directional" warnings. Patch 9 updates the corresponding board-level endpoint overrides and resolves those warnings.   Would you prefer that I squash patch 9 into patch 8 so that the graph remains valid within a single patch? Alternatively, we could move the endpoint assignment into the board DTS. However, since the EUD-to-controller mapping is on-SoC rather than board-specific, keeping it in the SoC DTSI appears to be the more appropriate placement. > >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + eud_con: endpoint { > > Let's keep an \n between the last property and the following subnodes > (like you did in the below hunk) > Ack Thanks Elson > >> + }; >> }; >> }; >> }; >> @@ -4989,6 +4995,7 @@ port@0 { >> reg = <0>; >> >> usb_1_dwc3_hs: endpoint { >> + remote-endpoint = <&eud_usb>; >> }; >> }; >>