[PATCH] net: fix sparse warning (plain int as NULL)

[PATCH] net: fix sparse warning (plain int as NULL)

[Jesper Juhl]

Here's a patch to fix a small sparse warning in net/ipv4/tcp_input.c :
net/ipv4/tcp_input.c:4179:29: warning: Using plain integer as NULL pointer

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
---

 net/ipv4/tcp_input.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.12-rc6-mm1-orig/net/ipv4/tcp_input.c	2005-06-12 15:58:58.000000000 +0200
+++ linux-2.6.12-rc6-mm1/net/ipv4/tcp_input.c	2005-06-12 23:58:41.000000000 +0200
@@ -4176,7 +4176,7 @@ int tcp_rcv_state_process(struct sock *s
 				 */
 				if (tp->rx_opt.saw_tstamp && tp->rx_opt.rcv_tsecr &&
 				    !tp->srtt)
-					tcp_ack_saw_tstamp(tp, 0, 0);
+					tcp_ack_saw_tstamp(tp, NULL, 0);
 
 				if (tp->rx_opt.tstamp_ok)
 					tp->advmss -= TCPOLEN_TSTAMP_ALIGNED;





Please CC me on replies.

Re: [PATCH] net: fix sparse warning (plain int as NULL)

[David S. Miller]

From: Jesper Juhl <juhl-lkml@dif.dk>
Date: Mon, 13 Jun 2005 00:05:33 +0200 (CEST)

> Here's a patch to fix a small sparse warning in net/ipv4/tcp_input.c :
> net/ipv4/tcp_input.c:4179:29: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

Please patch against Linus's tree, -mm has a ton of TCP changes
in it so this patch wouldn't apply to the current GIT tree
without rejects.

Thanks.

Re: [PATCH] net: fix sparse warning (plain int as NULL)

[Jesper Juhl]

On 6/13/05, David S. Miller <davem@davemloft.net> wrote:
> From: Jesper Juhl <juhl-lkml@dif.dk>
> Date: Mon, 13 Jun 2005 00:05:33 +0200 (CEST)
> 
> > Here's a patch to fix a small sparse warning in net/ipv4/tcp_input.c :
> > net/ipv4/tcp_input.c:4179:29: warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
> 
> Please patch against Linus's tree, -mm has a ton of TCP changes
> in it so this patch wouldn't apply to the current GIT tree
> without rejects.
> 
Since tcp_ack_saw_tstamp() in 2.6.12-rc6-git6 only takes two arguments
this patch is only relevant for -mm.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] net: fix sparse warning (plain int as NULL)

[David S. Miller]

From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Mon, 13 Jun 2005 23:21:56 +0200

> Since tcp_ack_saw_tstamp() in 2.6.12-rc6-git6 only takes two arguments
> this patch is only relevant for -mm.

Thanks for the clarification.

Re: [PATCH] net: fix sparse warning (plain int as NULL)

[Jesper Juhl]

On 6/13/05, David S. Miller <davem@davemloft.net> wrote:
> From: Jesper Juhl <jesper.juhl@gmail.com>
> Date: Mon, 13 Jun 2005 23:21:56 +0200
> 
> > Since tcp_ack_saw_tstamp() in 2.6.12-rc6-git6 only takes two arguments
> > this patch is only relevant for -mm.
> 
> Thanks for the clarification.
> 
You are welcome. Should I just send the patch on to Andrew for inclusion, or?

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html