public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
	LKML <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: IRQ routing problem in 2.6.10-rc2
Date: Sun, 24 Jul 2005 18:10:45 +0200	[thread overview]
Message-ID: <9a874849050724091051b62a81@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0507241711040.11580@yvahk01.tjqt.qr>

On 7/24/05, Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:
> >> PCI: Using ACPI for IRQ routing
> >> ** PCI interrupts are no longer routed automatically.  If this
> >> ** causes a device to stop working, it is probably because the
> >> ** driver failed to call pci_enable_device().  As a temporary
> >> ** workaround, the "pci=routeirq" argument restores the old
> >> ** behavior.  If this argument makes the device work again,
> >> ** please email the output of "lspci" to bjorn.helgaas@hp.com
> >> ** so I can fix the driver.
> >Have you tried the suggestion given "... As a temporary workaround,
> >the "pci=routeirq" argument..." ?
> >You could also try the pci=noacpi boot option to see if that changes anything.
> 
> Hi,
> 
> and what's the proper fix for pci=routeirq? I got a driver that is only
> maintained by myself and would like to fix up the issue.
> 
While I don't /know/ exactely what the proper fix is I'll venture a
guess based on the information in the text above : The driver probably
doesn't call pci_enable_device().
Quoting the message at bootup time "If this causes a device to stop
working, it is probably because the driver failed to call
pci_enable_device().".
Also, the Kernel Janitors TODO list
(http://janitor.kernelnewbies.org/TODO) has this to say about
pci_enable_device() :
  - ALL PCI drivers should call pci_enable_device --before-- reading
    pdev->irq or pdev->resource[].  irq and resource[] may not have correct
    values until after PCI hotplug setup occurs at pci_enable_device()
    time.  Many PCI drivers need to be evaluated and checked for this.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

  reply	other threads:[~2005-07-24 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-24 13:21 IRQ routing problem in 2.6.10-rc2 Pierre Ossman
2005-07-24 14:03 ` Pierre Ossman
2005-07-24 14:16 ` Jesper Juhl
2005-07-24 15:13   ` Jan Engelhardt
2005-07-24 16:10     ` Jesper Juhl [this message]
2005-07-24 21:08   ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a874849050724091051b62a81@mail.gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=greg@kroah.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox