Re: 2.6.13-rc6-mm1

Jon Smirl
2005-08-21T21:42:44Z

On 8/21/05, Benoit Boissinot <bboissin@gmail.com> wrote:
> On 8/19/05, Andrew Morton <akpm@osdl.org> wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/
> >
> > - Lots of fixes, updates and cleanups all over the place.
> >
> > - If you have the right debugging options set, this kernel will generate
> > a storm of sleeping-in-atomic-code warnings at boot, from the scsi code.
> > It is being worked on.
> >
> >
> > Changes since 2.6.13-rc5-mm1:
> > [...]
> > +gregkh-driver-sysfs-strip_leading_trailing_whitespace.patch
> > [...]
>
>
> it broke loading of firmware for me.(dmesg was flooded with
> "firmware_loading_store: unexpected value (0)")
>
> firmware.agent uses echo so there is a trailing newline. If i changes
> firmware.agent to uses echo -n it works correctly.
>
> Is this a bug or the correct behaviour ?

Somewhere there is a mistake in the white space processing code of the
firmware driver. Before this patch we had inconsistent handling of
whitespace and sysfs attributes. This patch forces it to be consistent
and will shake out all of the places in the drivers where it is
handled wrong. Sysfs attributes are now stripped of leading and
trailing white space before being handed to the device driver.

Fbdev sysfs attributes are also broken for white space handling and
need to be fixed. Overall the patch should be correct and it is the
drivers that are broken.

--
Jon Smirl
jonsmirl@gmail.com