From: Jesper Juhl <jesper.juhl@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Ingo Oeser <ioe@informatik.tu-chemnitz.de>,
Jason Thomas <jason@topic.com.au>,
Matthew Hawkins <matt@mh.dropbear.id.au>
Subject: Re: [PATCH 1/3] lib/string.c cleanup : whitespace and CodingStyle cleanups
Date: Sat, 24 Sep 2005 01:02:04 +0200 [thread overview]
Message-ID: <9a874849050923160258168853@mail.gmail.com> (raw)
In-Reply-To: <20050923230521.GA6915@mipter.zuzino.mipt.ru>
On 9/24/05, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Fri, Sep 23, 2005 at 11:48:44PM +0200, Jesper Juhl wrote:
> > Whitespace and CodingStyle cleanups for lib/string.c
> >
> > Removes some blank lines, removes some trailing whitespace, adds spaces
> > after commas and a few similar changes.
>
> > -char * strcpy(char * dest,const char *src)
> > +char *strcpy(char *dest, const char *src)
> ^^^
>
> Why? Seriously.
>
Two reasons
1) it matches the style most commonly used in the kernel
2) when I (and i suspect others) see
<foo> * <bar> my first thought is "multiplication"
but when I see
<foo> *<bar> my first thought is "ptr variable" or "function returning ptr"
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-09-23 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 21:44 [PATCH 0/3] lib/string.c cleanup Jesper Juhl
2005-09-23 21:48 ` [PATCH 1/3] lib/string.c cleanup : whitespace and CodingStyle cleanups Jesper Juhl
2005-09-23 23:05 ` Alexey Dobriyan
2005-09-23 23:02 ` Jesper Juhl [this message]
2005-09-23 21:51 ` [PATCH 2/3] lib/string.c cleanup : remove pointless register keyword Jesper Juhl
2005-09-23 21:53 ` [PATCH 3/3] lib/string.c cleanup : remove pointless explicit casts Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a874849050923160258168853@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=ioe@informatik.tu-chemnitz.de \
--cc=jason@topic.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@mh.dropbear.id.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox