From: Jesper Juhl <jesper.juhl@gmail.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Vadim Lobanov <vlobanov@speakeasy.net>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Unify sys_tkill() and sys_tgkill()
Date: Sat, 24 Sep 2005 21:15:35 +0200 [thread overview]
Message-ID: <9a874849050924121513b7a85d@mail.gmail.com> (raw)
In-Reply-To: <20050924163818.GA7339@wohnheim.fh-wedel.de>
On 9/24/05, Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> On Sat, 24 September 2005 16:52:28 +0200, Jesper Juhl wrote:
> >
> > [snip]
> > > +static int do_tkill(int tgid, int pid, int sig)
> >
> > I would probably have made this
> >
> > static inline int do_tkill(int tgid, int pid, int sig)
>
> Why? It would only return the original duplication in binary form and
> save a minimal amount of time for something already slow - a system
> call. With small caches, the code duplication could even waste more
> performance than the missing function call would gain you.
>
You are right, I didn't think that through properly.
Thank you for catching that.
> Other nits were well-picked.
>
Thanks.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-09-24 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-24 2:18 [PATCH] Unify sys_tkill() and sys_tgkill() Vadim Lobanov
2005-09-24 14:52 ` Jesper Juhl
2005-09-24 16:03 ` Serious time drift - clock running fast Howard Chu
2005-09-24 16:38 ` [PATCH] Unify sys_tkill() and sys_tgkill() Jörn Engel
2005-09-24 19:15 ` Jesper Juhl [this message]
2005-09-24 17:47 ` Vadim Lobanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a874849050924121513b7a85d@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox