The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Wensheng Wang <wenswang@yeah.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] hwmon: (pmbus/mp2869) Remove unused driver data
Date: Tue, 12 May 2026 11:37:00 -0700	[thread overview]
Message-ID: <9abc033a-329b-4bf1-b3d2-d4d745fc40b7@roeck-us.net> (raw)
In-Reply-To: <dcfcc82a93da77b55503998c5c7acf2a80c4a615.1778603083.git.ukleinek@kernel.org>

On Tue, May 12, 2026 at 06:28:56PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver doesn't make use of the i2c .driver_data and the of .data. So
> drop the useless and irritating assignments.
> 
> While touching all these lines, use named initializers for the i2c
> device ids and convert to the most common usage of spacing in such
> arrays.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Applied.

Thanks,
Guenter

  reply	other threads:[~2026-05-12 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 16:28 [PATCH v1 0/2] hwmon: (pmbus/mp2869) Two cleanups about device ids Uwe Kleine-König (The Capable Hub)
2026-05-12 16:28 ` [PATCH v1 1/2] hwmon: (pmbus/mp2869) Remove unused driver data Uwe Kleine-König (The Capable Hub)
2026-05-12 18:37   ` Guenter Roeck [this message]
2026-05-12 16:28 ` [PATCH v1 2/2] hwmon: (pmbus/mp2869) Drop unjustified __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-05-12 18:38   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9abc033a-329b-4bf1-b3d2-d4d745fc40b7@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=wenswang@yeah.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox