The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] flow_offload: fix flow_offload_has_one_action() kdoc
Date: Thu, 11 Apr 2024 12:32:44 +0100	[thread overview]
Message-ID: <9abe0c09-efa5-4ff4-b423-469a2dd34ef8@amd.com> (raw)
In-Reply-To: <20240410114718.15145-1-ast@fiberby.net>

[Removed my old email address from CC]

This LGTM, thank you.

Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>

On 10/04/2024 12:47, Asbjørn Sloth Tønnesen wrote:
> include/net/flow_offload.h:351: warning:
>   No description found for return value of 'flow_offload_has_one_action'
> 
> Fixes: ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
>  include/net/flow_offload.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 314087a5e1818..7726b4a97050e 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -345,7 +345,7 @@ static inline bool flow_action_has_entries(const struct flow_action *action)
>   * flow_offload_has_one_action() - check if exactly one action is present
>   * @action: tc filter flow offload action
>   *
> - * Returns true if exactly one action is present.
> + * Return: true if exactly one action is present.
>   */
>  static inline bool flow_offload_has_one_action(const struct flow_action *action)
>  {

  reply	other threads:[~2024-04-11 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 11:47 [PATCH net-next] flow_offload: fix flow_offload_has_one_action() kdoc Asbjørn Sloth Tønnesen
2024-04-11 11:32 ` Pieter Jansen van Vuuren [this message]
2024-04-12  2:35   ` Jakub Kicinski
2024-04-12 13:40     ` Pieter Jansen van Vuuren
2024-04-12  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9abe0c09-efa5-4ff4-b423-469a2dd34ef8@amd.com \
    --to=pieter.jansen-van-vuuren@amd.com \
    --cc=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox