From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905BBC7618B for ; Thu, 25 Jul 2019 14:38:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66345218EA for ; Thu, 25 Jul 2019 14:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="qW9lqXmW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387646AbfGYOi5 (ORCPT ); Thu, 25 Jul 2019 10:38:57 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44006 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfGYOi4 (ORCPT ); Thu, 25 Jul 2019 10:38:56 -0400 Received: by mail-pf1-f196.google.com with SMTP id i189so22870196pfg.10 for ; Thu, 25 Jul 2019 07:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=dM0tavbTao+XHLEjp4zxGd1Wc/gjo0u4n5AfPPLxYxY=; b=qW9lqXmWOxkhdiOYGKrIWBHJs6675m6ojicr27ola+XCc/laXgrTsFw66srMTfptKM E79JHYUrgD0swB3l5aRCQD23i2Yw2BoCoSowYMi0YrTZ439hPJPdYEpr+IPidFY7bJ6w pYFJoxehPvvEcBRzxjNtLlvrWBiePB0+ymsj/T7HaZBy/uLx765/XOGY8lMSK+q1l0vj 2Tg3XPrMqO++R7wch3UgVTEumv9q1vy/A7yceOCUX3sSgckKX3VdA/enhcH4mOqaTvj5 3sHr+pvZlJx5Ev1BtEhINmnp3Q8GES5JIb0iUg15mcxR6OZc0CGwqWYCVo6sw3ar6rfF lCug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dM0tavbTao+XHLEjp4zxGd1Wc/gjo0u4n5AfPPLxYxY=; b=LMDWpnPm8O7GxEWc8z6GIvMUdzuXR/SyWTgwIrc6Fva8Ijo1+wSwBah8Ba5gVt3pbC EnPcuBV31/Q47YfGqV+uU9KqsE6kbX6KBTFNy5ynbpiyV8YYSp1KPvc+0v8wWxPGQS3/ hERPD/aWktwmfXbxdNna8eyyb4PZgcQ0OtrVJrOEpxfZtbx8pf+nc18Fg4pTQd4obiUl 8pSQHIZPEpkdeGpNCpbkU6p8jG7AdvWBJM7fhqId7d0uIGa0kFmabTBEFiErZbE8v/7x CqhFrEUD1aXDHQdKCMbzhgf06misf6pUW90sWbdFN3toe8GeqdqZwm4BE9tYOkKn3ijG TL3A== X-Gm-Message-State: APjAAAXXcLP3cxR90D3meHShT8rc3IhMXd2B2ilKrCG/bhIxVg3/yFIr i9oKePE1RwTUwAohyX+gVxo= X-Google-Smtp-Source: APXvYqxbW1kdSdI2g5El3DdDVDtndVrRVVH5xAYU7zqmtvAOT6CVSwyux9F/5Aztl1fxRRkV7d9XhQ== X-Received: by 2002:a63:c44c:: with SMTP id m12mr48061734pgg.396.1564065536100; Thu, 25 Jul 2019 07:38:56 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id z4sm39432142pgp.80.2019.07.25.07.38.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 07:38:55 -0700 (PDT) Subject: Re: [PATCH v10 5/5] overlayfs: override_creds=off option bypass creator_cred To: Amir Goldstein Cc: linux-kernel , kernel-team@android.com, Miklos Szeredi , Jonathan Corbet , Vivek Goyal , "Eric W . Biederman" , Randy Dunlap , Stephen Smalley , overlayfs , linux-doc@vger.kernel.org References: <20190724195719.218307-1-salyzyn@android.com> <20190724195719.218307-6-salyzyn@android.com> From: Mark Salyzyn Message-ID: <9acceab1-86af-758a-ec00-8f6d33f3da87@android.com> Date: Thu, 25 Jul 2019 07:38:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/19 11:14 PM, Amir Goldstein wrote: >> +void ovl_revert_creds(const struct cred *old_cred) >> +{ >> + if (old_cred) >> + revert_creds(old_cred); >> +} >> + > Mark, > > Not sure if you have seen my "shutdown" patches: > https://lore.kernel.org/linux-fsdevel/20190715133839.9878-4-amir73il@gmail.com/ Good to know! > > I am fine with this patch, but would like to request that you add @sb arg > to the ovl_revert_creds() helper, so it is more useful for other things in the > future that scope the underlying layers access (like shutdown). Will respin and retest. -- Mark