From: Jiri Slaby <jirislaby@kernel.org>
To: David Laight <david.laight.linux@gmail.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Miguel Ojeda <ojeda@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] jiffies: Cast to unsigned long for secs_to_jiffies() conversion
Date: Fri, 31 Jan 2025 08:05:02 +0100 [thread overview]
Message-ID: <9ae171e2-1a36-4fe1-8a9f-b2b776e427a0@kernel.org> (raw)
In-Reply-To: <20250130201417.32b0a86f@pumpkin>
On 30. 01. 25, 21:14, David Laight wrote:
> On Thu, 30 Jan 2025 18:43:17 +0000
> Easwar Hariharan <eahariha@linux.microsoft.com> wrote:
>
>> While converting users of msecs_to_jiffies(), lkp reported that some
>> range checks would always be true because of the mismatch between the
>> implied int value of secs_to_jiffies() vs the unsigned long
>> return value of the msecs_to_jiffies() calls it was replacing. Fix this
>> by casting secs_to_jiffies() values as unsigned long.
>
> Surely 'unsigned long' can't be the right type ?
> It changes between 32bit and 64bit systems.
> Either it is allowed to wrap - so should be 32bit on both,
> or wrapping is unexpected and it needs to be 64bit on both.
But jiffies are really ulong.
--
js
suse labs
next prev parent reply other threads:[~2025-01-31 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 18:43 [PATCH] jiffies: Cast to unsigned long for secs_to_jiffies() conversion Easwar Hariharan
2025-01-30 19:25 ` Easwar Hariharan
2025-01-30 20:14 ` David Laight
2025-01-31 7:05 ` Jiri Slaby [this message]
2025-01-31 8:10 ` Geert Uytterhoeven
2025-01-31 17:55 ` Easwar Hariharan
2025-01-31 17:59 ` Easwar Hariharan
2025-02-03 20:42 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae171e2-1a36-4fe1-8a9f-b2b776e427a0@kernel.org \
--to=jirislaby@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=david.laight.linux@gmail.com \
--cc=eahariha@linux.microsoft.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luiz.von.dentz@intel.com \
--cc=ojeda@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox