From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E893248A2C5 for ; Wed, 6 May 2026 16:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084063; cv=none; b=gSrNI+5IrAkTcfiWWnYhjsLZMdK+tXpO4bdgi5dT4RBvfKWvmXNYjIgalhRBTz6FXjG8HnMQKKbz5M1vC7350cHDY5CVxbU0CHUqAaDf0mA+u7L4xz29YgPnVTeE5n1SrRRZPWpqrv+Ueh9lButYj5K1bvV8WtdN9YJS2AsRCvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084063; c=relaxed/simple; bh=T+hwVHoy+/HW70H4b4ny1tz+u9z10JcY5ob6OwvauXQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i09QBIsaUcFudWskchTf1axjdDl0rgYoue9bFk+E+o4XsrBwHgorjdFUkYnyPN1ZoWx/Rl4W+7sxO0w3P9ygf271UjJXOYfvdNDnFg3kG8uXOS6cO2t6EuQAXFhySbQqpiFWgu1yb+VUtVZeK7Wddiu3JhDI/86q2Kw+JqrsObM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oqAg1DQL; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oqAg1DQL" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a887ebb416so1128257e87.2 for ; Wed, 06 May 2026 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778084056; x=1778688856; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QpS9p5To8P4BftdAlsDaBegfX21bw2fBoqWrx1dYiXE=; b=oqAg1DQLyT1XmAPaltQ+v5D5NGDIUFmqL8DMIIgdEXMsXXu8D11qsPAtu7mycGuWIN u2jGvpcEqLaxG2CqMcsBt6HFrhfmjqQJif2P/CjuB1e2CLyomhLQ58/A/mq3aBtNC0ra FjL4kjdxZh9uUrx97XmXVPvgxEb2You1mx9bPwdAekIi8rnbh77547Htce3/Pm+T8af/ 4ArDZwLqL/XaEKpR9AT7GlNzyACVwwrpT49MNaVbgGO2Viku2SMFqhM4OGfTKkd3aAuL LMqZdQ0GKmgsiOZszGaknj/YovO8af3f65RcEoq+gAFf8t0gTMSOvEYDv3PX8huWQQdR rEWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778084056; x=1778688856; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QpS9p5To8P4BftdAlsDaBegfX21bw2fBoqWrx1dYiXE=; b=PcvnR+EjD82IdPNNHIOSCkVEh3Y3R4gDXLPRKLY3b83OJC+ueCtuykjzxVI1y7/S4O 1g/BRGi8ETY0CdutAukjUEY6QZ+eTHQ50KMsbD5mXlrbT8NMKmq7xXPd9qvXs4mnaEIY pfCPBFLPEyEL0rleHm/ksxuDcrZTkShn4/YVLaU6MCVso60e5rFoYjzBUuZPIRpCQldS GUFvgV++/27Dhlm1gTScxkQDrCFKLt0nVkfBSKZCPm/gEW9tklIKP6k/veo4eZb+AFUg N5YLfZwGJEc54wLT3BPyiiFuK4HH8VtVAVV7GScfywQiF8smRulgQyBGR9cjJ3ff/xOP fH5g== X-Forwarded-Encrypted: i=1; AFNElJ+Kbd4I2sZlMx44LHMSgRU+EsQe+GXjrWG/etVzh1Hka7Ildklenvs3d/voNAMDe4Tcd0cdqYzHJ6mqQtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwE+v/2eyMyVgRgbSzOPTt6IMOpPZfTFQV7phSgyIvCd50rp5wJ H0Xb4mnN0C/yJAvV880Ho6Y5VCKfkCUsvY39AgLX6v/RxuvCBnx1a4p9 X-Gm-Gg: AeBDievotEyw5rDm+GBAjZIbonjbmCLms+BKalP+vwx6X0Hk0zI28XlyvMvexDvtmme riRBYJi7QDbEzct/TgknlZHv5238TdPwBTWxom9Xip74xcGELclA8onhUkcbnzu+DE3RntmIJ21 4d7fOuRtHhCC1VMceHtH5vlDTa29NIFkFLmQDJn1CiK3L6GZ5VyO5naT0Ka3as1mjuP4IossKOz gDlg11//fRcxJxBWcQ00H/MugO00F0V9q25Rn0RHn4NlELl/yreRbq2vCZi9saFrOgRJHGSWdk4 ZUFjzODTtd14R/EIyiBbR3tSQ4HPGhEI3d6VWfQUM3GPyXqZBpX8yhIRwLUOVjFK9Lqn4AJPK1/ u4C8ZuzTojYMzOyyNiK1S/mLuGmqHBcniGdhtyqyeaicVa70UdB+4ZBtdZaJD4x78I2j06g+5qN IkZeNmAAslxxwfZpvFsYmP9VtIuZfFQfaT8f/MHsDo9CzZ65VJwK56bb03eRZdeLvp2x8RQ4lya A== X-Received: by 2002:a05:6512:308b:b0:5a8:89c5:2c0f with SMTP id 2adb3069b0e04-5a889c52e35mr1306160e87.25.1778084055726; Wed, 06 May 2026 09:14:15 -0700 (PDT) Received: from [192.168.2.20] (109-252-156-195.dynamic.spd-mgts.ru. [109.252.156.195]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a86aa3d540sm3844372e87.17.2026.05.06.09.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 09:14:14 -0700 (PDT) Message-ID: <9af23def-ffa7-4f68-8aa1-ab080b6c1c4f@gmail.com> Date: Wed, 6 May 2026 19:14:07 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] media: nvidia: tegra-vde: Fix iommu_map_sgtable() return value check To: Mikko Perttunen , Thierry Reding , David Airlie , Simona Vetter , Jonathan Hunter , Mauro Carvalho Chehab , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20260421-iommu_map_sgtable-return-v1-0-fb484c07d2a1@nvidia.com> <20260421-iommu_map_sgtable-return-v1-4-fb484c07d2a1@nvidia.com> From: Dmitry Osipenko Content-Language: en-US In-Reply-To: <20260421-iommu_map_sgtable-return-v1-4-fb484c07d2a1@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 21.04.2026 07:02, Mikko Perttunen пишет: > Commit "iommu: return full error code from iommu_map_sg[_atomic]()" > changed iommu_map_sgtable() to return an ssize_t and negative values > in error cases, rather than a size_t and a zero. > > Update tegra_vde_iommu_map() to correctly check for errors from > iommu_map_sgtable. > > Fixes: ad8f36e4b6b1 ("iommu: return full error code from iommu_map_sg[_atomic]()") > Signed-off-by: Mikko Perttunen > --- > drivers/media/platform/nvidia/tegra-vde/iommu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/nvidia/tegra-vde/iommu.c b/drivers/media/platform/nvidia/tegra-vde/iommu.c > index b1d9d841d944..824d2aa80a43 100644 > --- a/drivers/media/platform/nvidia/tegra-vde/iommu.c > +++ b/drivers/media/platform/nvidia/tegra-vde/iommu.c > @@ -25,6 +25,7 @@ int tegra_vde_iommu_map(struct tegra_vde *vde, > unsigned long shift; > unsigned long end; > dma_addr_t addr; > + ssize_t map_err; > > end = vde->domain->geometry.aperture_end; > size = iova_align(&vde->iova, size); > @@ -36,11 +37,11 @@ int tegra_vde_iommu_map(struct tegra_vde *vde, > > addr = iova_dma_addr(&vde->iova, iova); > > - size = iommu_map_sgtable(vde->domain, addr, sgt, > - IOMMU_READ | IOMMU_WRITE); > - if (!size) { > + map_err = iommu_map_sgtable(vde->domain, addr, sgt, > + IOMMU_READ | IOMMU_WRITE); > + if (map_err < 0) { > __free_iova(&vde->iova, iova); > - return -ENXIO; > + return map_err; > } > > *iovap = iova; > Acked-by: Dmitry Osipenko