From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A6B265CC5 for ; Fri, 8 Aug 2025 08:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754643507; cv=none; b=r4X257Z00Kh88/cvR37XlYzFuDOau4cFKUs6NhSlIy7uBwnpKsh8uM9I7lZk0BS9Cz7l4P90U5AYdSqDF3qb6qyHJO6lqz31/mmY9XtdJY3ltxNO1kvkTGImP8ckUm/gOfw2GsEPiO9hSY9kD/P1eKSN5YR/zZ/GRB7pJCLyvMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754643507; c=relaxed/simple; bh=t6DFxcyLHMC844tzFgeCODmtYEMwsh8pJywnazP2Xqo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JIgkejmZMqW9zLqKutZIuzmuTWQKZ0MM6nnnh5gOyzapUoljfr/km4m27iCU0IsP10VwVJZxkx4iRzo2quojqU41pQgn2W9aFmYisgIr412kh5KxrCIzTNTTUThwg34J0l/t+kKs4MoQQ0TaLgEVZ4PFytDSi0npAW5jSGbdpvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tej4IWsX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tej4IWsX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5787I61N003513 for ; Fri, 8 Aug 2025 08:58:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R6Q9n1VBcmPjQskeZ/W9TfLHZuyYCWbxE9Bhoq5xM3o=; b=Tej4IWsX+JmGeVih QSTcVIuaVYUBxkH2Im54AmnuSffT3Spd1cVyUYPXW8bkSPidIuSLIGmbl0kGo2vz k7soJ6D99KF8nTutfdtUlYm75nq8UFgTkWohLTcaNCLAlll2DDDWrOLmlSZDmwrv ka6YRXkaylQzKU7E4/W3s9GYhOKZ6r45OFhKMgGSJv7mKy50uTpJk3QqPB1Br70m xFqMc+l9ddQW9j0Qb0AuqHqyBmx+AVyjsyDBe4E+a90Gb6qLOZTNEC9OlsjzJ4aB aaaT+xbR7fff7DjR17v6OOexpWHE4KE0HiW4BzLu4HePwZfh+bgjw7IoyHUGSETY sW/bbA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48bpw01kb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 08 Aug 2025 08:58:24 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6f539358795so4827986d6.3 for ; Fri, 08 Aug 2025 01:58:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754643504; x=1755248304; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R6Q9n1VBcmPjQskeZ/W9TfLHZuyYCWbxE9Bhoq5xM3o=; b=qycLycHdLVXO3V7ItMzzMK2JFxiu3nt6K5fPlezcYqwZyq88a/Tkc6n49JeB0qrlvO UjutZ626BqvgntNr3lkclcxbJc2q8Q9/XsfWyE8IyViDGre4eH5gUmMR7vBY+Z0ahsxZ izoXAAa+KzGGCq42lV5xROS94CT16N/arkY3pUEhzyjZOc8n8uxGxWSyjFjK2rS2z62w t/wPBNSdkMxuHElJfrZmwjFcmG80bTtf0r2Qdb9y2T43lqhlgyS5rF25rEG8MM2XUduC As4Vo0xqEXTcFa/vd7GFG/kNOhNsIKGIzeUj99ndS1sX9BD6zQImu5zHr0TfvG+o2Eus g3gA== X-Forwarded-Encrypted: i=1; AJvYcCV57jnmB4FWdJ2YVgNHoj684C/aRP/EZdBYbTZbc3PCiE45l0euWfrJx1xYy2aip5MFNKSjRnquf8AEekc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8Nj1wTPMFw/vsaC27wOkt2upu2g0qqTZIMtRmBt0Fp7FitilI EjUQXy3YCF/QYIvIp/f3v6MNycp9Fy07lRC9E0wuodeSIzl/ymRcm5NA+/4TFnbKad/sSo4yP8R HlTfu86jNUrj0pdYcfpDwjo5F4+T5TNicO+1p5sLui+043jj2v4Iku39cOmW5lMRMiVY= X-Gm-Gg: ASbGncsjJGJ2/tLrfWz2l7d1dmLxzUI6QuTQxw19n0m0XCG1iNA47DUUdwtoPLobrFV aZjWEyETt6V1RGMUtwNQ1gRHSikvLAo66ndj/N3tdDdkzxQoKxyGzSIm3a3edcTeh/ojCgvWNRq zcnzI0y4t+eD0/9KKHykSRhuY0Her8akAFoD/YcrI9vMNAI4xMjGjw57bN531O2Yo1261NIyxpN IhBUTFVh1xBxfq54+eJlpkjwNSBcV7pA1zdTEmCmq3ntaMt3H1/2XZZ13ikQJx9GQF0CqjtogPB ujmIrgV821K68kpAm0c6ui99IqrwMI0R/ffy3hBXFz/pgTAClFILm6CnNOsFCp3y5qe/6/bNXQ5 Uo8F8for216CgKWrBcQ== X-Received: by 2002:ac8:7e94:0:b0:4ab:67a3:ec09 with SMTP id d75a77b69052e-4b0aed20c07mr17186281cf.6.1754643503775; Fri, 08 Aug 2025 01:58:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh16OD+ZoyT6jx0iozIhaDryFGFQR4TtUyX+fYll//iyn3c+QGTMne8GP/ly3AC+UnMV9iww== X-Received: by 2002:ac8:7e94:0:b0:4ab:67a3:ec09 with SMTP id d75a77b69052e-4b0aed20c07mr17186061cf.6.1754643503317; Fri, 08 Aug 2025 01:58:23 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0a1bf9sm1460998466b.31.2025.08.08.01.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 01:58:22 -0700 (PDT) Message-ID: <9af71063-0629-4ccc-bc76-3fb588677bf4@oss.qualcomm.com> Date: Fri, 8 Aug 2025 10:58:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/4] arm64: dts: qcom: sm8750: add max-microamp for UFS PHY and PLL supplies To: Krzysztof Kozlowski , Nitin Rawat Cc: vkoul@kernel.org, kishon@kernel.org, mani@kernel.org, conor+dt@kernel.org, bvanassche@acm.org, andersson@kernel.org, neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com, konradybcio@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250806154340.20122-1-quic_nitirawa@quicinc.com> <20250806154340.20122-3-quic_nitirawa@quicinc.com> <20250808-calm-boa-of-swiftness-a4a7ce@kuoka> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250808-calm-boa-of-swiftness-a4a7ce@kuoka> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Q1lCufK0zKTNUxsZ1-46Pz0T_uZ4BFqa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA2MDAwOSBTYWx0ZWRfX0VhPeRzLxmyw +KqNilXn0Bp7NAM7NlxBsEyLpkPGurZ2htLV9maKximYId3pf2h1G7gk2vlKOvIFEmXf9Ht08AP XU0u+8OmeWcmvOMYw0VnZbNwn1JsvEbEg2FSkuEbNAuJjXTbCLqjvL7+f/DQf3uEYHGh/8AqSkI Vy5V7y+HfAQsFhBRhhdIzQA9vtXdxOOXpnARaPD1oMFs25PnYLWD5zfbnUtrzQJCVxG24Lf9red +esFW9O915FtqCW4mxpuhmZpdsV8L7wMa57GKVDVdx+5xUh3mzq31VmI6PCNt11/8ltT1gIupFN Fvaxps3x0AtYcpgt3bs1iNAqUe54jYyf5leFF2Xm1Nvlbwoy+gdUoXQqNSuOrzy+tinSIZ7Jc4m KPkvBMhX X-Proofpoint-ORIG-GUID: Q1lCufK0zKTNUxsZ1-46Pz0T_uZ4BFqa X-Authority-Analysis: v=2.4 cv=NsLRc9dJ c=1 sm=1 tr=0 ts=6895bc30 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=WmDcBHyyyws--uAXJ9AA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-08_02,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508060009 On 8/8/25 9:29 AM, Krzysztof Kozlowski wrote: > On Wed, Aug 06, 2025 at 09:13:38PM +0530, Nitin Rawat wrote: >> Add `vdda-phy-max-microamp` and `vdda-pll-max-microamp` properties to >> the UFS PHY node in the device tree. >> >> These properties define the maximum current (in microamps) expected >> from the PHY and PLL regulators. This allows the PHY driver to >> configure regulator load accurately and ensure proper regulator >> mode based on load requirements. > > That's not the property of phy, but regulator. > > Also reasoning is here incomplete - you just post downstream code. :/ The reason for this change is good, but perhaps not explained clearly All of these values refer to the maximum current draw that needs to be allocated on a shared voltage supply for this peripheral (because the supply's capabilities change depending on the maximum potential load at any given time, which the regulator driver must be aware of) This is a property of a regulator *consumer*, i.e. if we had a chain of LEDs hanging off of this supply, we'd need to specify NUM_LEDS * MAX_CURR under the "led chain" device, to make sure that if the aggregated current requirements go over a certain threshold (which is unknown to Linux and hidden in RPMh fw), the regulator can be reconfigured to allow for a higher current draw (likely at some downgrade to efficiency) Konrad